global: linter and deprecated #108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tomholford <tomholford@users.noreply.github.com>
tomholford
force-pushed
the
th/devex-linter-deprecated
branch
from
650bff7 to
49e120a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This is a non-mission critical PR that addresses linter issues, replaces a deprecated call, and adds a
maketask.The impetus for it is that I recently got back into golang, and have been studying various codebases to further my understanding. Moreover, I have been using
wgfor some time, so as a token of gratitude for the hard work of Jason et al, I also hope to pay it forward by offering a small contribution.Changes
master; the final change could potentially affect behavior so I left it alone for nowrand.Seedbenchmarktask to Makefile