Fix the build workflow broken by #989 #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move repetitive build commands into environment variables * Merge 'https://github.com/mceachen/better-sqlite3/tree/dry-gha-989' Co-authored-by: mceachen <mceachen@users.noreply.github.com> --------- Co-authored-by: mceachen <mceachen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#989 was broken by the additional commit mceachen@a99e3d3 and this PR contains the fix from @mceachen.
I somehow didn't notice the error when merging that branch with the original PR branch. Oh well 🤷🏽.
BTW @mceachen, your fix branch is apparently sourced from f190fef, hence the conflict. But I went ahead and merged it anyway since you requested to do so. I'm guessing you aren't able to approve your own revert either.