Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resizing issue when resize to minimal dimension with resizer other than right-bottom resizer #42

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

archer0302
Copy link

Changes to current unit tests:

  1. Instead of testing on a minimal dimension of (0, 0), now testing on a size that's bigger than 0.
  2. The calculation of position when node is at minimal dimension was not quite correct, now is expecting the right position.

@archer0302 archer0302 changed the title refine the existing tests for resizing to minimal dimension resizing issue when resize to minimal dimension with resizer other than right-bottom resizer Jun 17, 2024
Copy link

@steven0x51 steven0x51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested code locally, issue fixed

@archer0302 archer0302 merged commit 497ec4e into master Jun 18, 2024
2 checks passed
@archer0302 archer0302 deleted the archer/WI00715545/resizer-behaviour branch June 18, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants