No more timer (setText, setHtml) #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Next step (but this is an architectural/coupling challenge):
|
|
Good ideas. Please create enhancement issues. |
|
See #12 from March 24. |
|
@polco Code review is welcome |
|
This is still not in? |
|
I thought it was 😓 |
|
yeah it's good ! |
micky2be
added a commit
that referenced
this pull request
Aug 29, 2014
No more timer (setText, setHtml)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the option to be able to pass a function + interval to setText.
As already discussed, this is no used by anyone since long time. (close #11)
Tagged the method as deprecated.
Having the instantiation and the assignment is a bit useless, and can create sometimes bugs for devs.
Changed primitives name in JSDOC to small caps (string, number, boolean).