Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code integration tests to be more maintainable. #3446

Merged
merged 13 commits into from
Jan 2, 2020
Merged

Update code integration tests to be more maintainable. #3446

merged 13 commits into from
Jan 2, 2020

Conversation

MartijnHols
Copy link
Member

@MartijnHols MartijnHols commented Jan 1, 2020 •
edited
Loading

  • Move the log zips into spec folder. This makes it less suggestive that you should only have 1 integration tests, allows us to more execute these tests separately and allows us to colocate the log files
  • Fix bug where all channeling events were triggered twice by disabling the ChannelingShared module that caused the bug
  • Fix a bunch of console warnings/errors when running (integration) tests
  • Separate test workflow jobs by type
  • Add yarn scripts to run a specific test type
  • Build the app during testing phase to speed up pipeline

TODO:

@MartijnHols MartijnHols requested a review from emallson January 1, 2020 22:29
emallson
emallson approved these changes Jan 1, 2020
View reviewed changes
Copy link
Collaborator

@emallson emallson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me 👍

@emallson
Copy link
Collaborator

emallson commented Jan 1, 2020

@MartijnHols not sure if its a github hiccup or problem with the new workflow spec, but its stuck at Tests Expected — Waiting for status to be reported

@MartijnHols
Move integration tests to its own folder
9e80127 
This makes it less suggestive that you should only have 1 integration tests, allows us to more execute these tests separately and allows us to colocate the log files
@MartijnHols
Split tests into 3 jobs
38d634d
@MartijnHols
Add yarn commands for each test build step
5918f12
@MartijnHols
Update CI: run tests in band since CI is resource limited
1160845
@MartijnHols
Build the app during testing phase to speed up pipeline
f7857c9 
Build no longer has any side-effects and it doesn't have much overlap with the other jobs
@MartijnHols
Skip ThroughputPerformance during tests to fix its console warning
8862b96
@MartijnHols
Add report code to downloaded logs
0c07c12
@MartijnHols
Set reportCode for integration tests
127ab95
@MartijnHols
Fix irrelevant warning in snapshot tests about keys
e5df1b7
@MartijnHols
Fix issue where all channeling events were triggered twice
9b3adb3
@MartijnHols
Fix AbilityRequirement propTypes
dfe5e7e
@MartijnHols
Add changelog entry
43f89a7
@MartijnHols MartijnHols force-pushed the feature/move-integration-tests-and-co-locate branch from 17dad7f to 43f89a7 Compare January 2, 2020 07:38
@MartijnHols MartijnHols merged commit 70416e3 into master Jan 2, 2020
@MartijnHols MartijnHols deleted the feature/move-integration-tests-and-co-locate branch January 2, 2020 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emallson emallson emallson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MartijnHols @emallson