Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CORE] ArmorStandEditor 1.19-35 #40

Merged
merged 91 commits into from
Jun 22, 2022
Merged

[CORE] ArmorStandEditor 1.19-35 #40

merged 91 commits into from
Jun 22, 2022

Conversation

Wolfieheart
Copy link
Owner

@Wolfieheart Wolfieheart commented Mar 7, 2022 •
edited
Loading

Official Changelog:

[CORE] Changes

Changes to the core of the plugin - Ex: New Features, Bug Fixes, Performance Improvements etc.

  • [CORE] Re-implementation of PlotSquared, WorldGuard, GriefPrevention and Towny Protections
  • [CORE] Updated Translations
  • [CORE] Metrics Fixes for Bstats
  • [CORE] Bug Fixes
  • [CORE] Permission Improvements for OP Users
  • [CORE] Performance Improvements
  • [CORE] Introduction of CustomModelData Support
  • [CORE] Update Readme.md for Discord Support
  • [CORE] More Debug Output
  • [CORE] 1.19 Update
  • [CORE] Code Review Remarks from SonarCloud and CodeFactor

[CI] Changes

Changes relating to the Continuous Integration of other Plugin APIs etc.

  • [CI] Massive Dependency Updates
  • [CI] Java 18 Builds (futureproofing)
  • [CORE/CI] Move to PaperMC API - Investigated and not feasible at the moment.

[DOC] Changes

NEW: Plugin Documentation

  • [DOC] Introduction of more Up To Date Wiki for Plugin Documentation
  • [DOC] Introduction of Contributing File for PRs

@Wolfieheart Wolfieheart marked this pull request as draft March 7, 2022 12:00
@Wolfieheart Wolfieheart added dependencies Pull requests that update a dependency file enhancement New feature or request java Pull requests that update Java code P1: Extra Debug Required Extra Debug Effort Required labels Mar 7, 2022
@sonarcloud
Copy link

sonarcloud bot commented Mar 7, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Wolfieheart
Copy link
Owner Author

Pleasant surprise to see the code still works as intended after this implementation. Looking for more Protections to Potentially add!

@sonarcloud
Copy link

sonarcloud bot commented Mar 8, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Mar 11, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

0.0% 0.0% Coverage
1.9% 1.9% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Mar 11, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

0.0% 0.0% Coverage
1.9% 1.9% Duplication

@Wolfieheart
Copy link
Owner Author

Wolfieheart commented Mar 16, 2022 •
edited
Loading

Publishing a Pre-Release 1 of this:

NOTE from Wolfie: This is a pre-release version of the next version of ArmorStandEditor.
As stated in the Readme file, this is for testing purposes only and limited support will be provided. If there are any issues, please report them via: https://github.com/Wolfieheart/ArmorStandEditor-Issues/issues/new/choose

Major Changes between 1.18.2-34 and 1.18.2-35pre1

  • Introduction of WorldGuard, Plotsquared and GriefPrevention Protection
  • Rework of the CanEdit class to benefit from added protection
  • Addition of Russian Translation File
  • Fix for BStats not correctly detecting the English Language File.
  • Update of various dependencies.

Report issues to https://github.com/Wolfieheart/ArmorStandEditor-Issues/issues/new/choose

Download Link Removed.

@Wolfieheart
Copy link
Owner Author

Issue to be solved here (later today most likely): Wolfieheart/ArmorStandEditor-Issues#28

@Wolfieheart
Copy link
Owner Author

Things remaining to be added:

@sonarcloud
Copy link

sonarcloud bot commented Mar 23, 2022

Please retry analysis of this Pull-Request directly on SonarCloud.

@sonarcloud
Copy link

sonarcloud bot commented Apr 6, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

0.0% 0.0% Coverage
1.8% 1.8% Duplication

@Wolfieheart
Copy link
Owner Author

OK WARNING ABOUT COMMIT JUST MADE:

  • Permission to ignore protections is for Staff Use Only per a suggestion on the Forms for Spigot
  • asedit.* has now been implemented, BUT I recommend only giving this to staff/admin/mod/insert team name here as it sends important update notifications
  • This is done via permissions and not via the configs for now - This could change in the future.

@sonarcloud
Copy link

sonarcloud bot commented May 10, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

0.0% 0.0% Coverage
1.7% 1.7% Duplication

@Wolfieheart
Copy link
Owner Author

Addding @Gyztor and therefore @Havens-Edge-MC to the authors list. They have some fantastic ideas and contributions, which I seen when checking (periodically) for active forks. Will definately be keeping an eye on!

Pre-Release 2 Coming to Releases SOON!

@Wolfieheart Wolfieheart mentioned this pull request May 10, 2022
Closed
@sonarcloud
Copy link

sonarcloud bot commented May 12, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

0.0% 0.0% Coverage
1.7% 1.7% Duplication

@Wolfieheart Wolfieheart force-pushed the dev/1.18.2-35 branch 2 times, most recently from f1e7c3e to d11de4c Compare May 14, 2022 19:45
@sonarcloud
Copy link

sonarcloud bot commented May 16, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

0.0% 0.0% Coverage
1.3% 1.3% Duplication

@Wolfieheart Wolfieheart added the bug Something isn't working label May 17, 2022
@Wolfieheart
[CORE] Version Bump to 1.18.2-35
d020ba7 
Signed-off-by: Wolfieheart <xMakeItRain94@gmail.com>
Signed-off-by: Github <xMakeItRain94@gmail.com>
@Wolfieheart
[MVN] Introduce WorldGuard, Plotsquared, GriefPrevention Addons
10e11c1 
Signed-off-by: Wolfieheart <xMakeItRain94@gmail.com>
Signed-off-by: Github <xMakeItRain94@gmail.com>
@Wolfieheart
[CORE] Introduce WorldGuard Protection
1fabc77 
Signed-off-by: Wolfieheart <xMakeItRain94@gmail.com>
Signed-off-by: Github <xMakeItRain94@gmail.com>
@Wolfieheart
[CORE] PlotSquared and Towny Implementations
d637430 
Signed-off-by: Wolfieheart <xMakeItRain94@gmail.com>
Signed-off-by: Github <xMakeItRain94@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 2, 2022

Please retry analysis of this Pull-Request directly on SonarCloud.

@Wolfieheart Wolfieheart changed the title ArmorStandEditor 1.19.x-35 [CORE] ArmorStandEditor 1.19-35 Jun 7, 2022
@Wolfieheart
[CORE] Version Bump - Spigot 1.19 Support as base API
519e02b 
Signed-off-by: Wolfieheart <xMakeItRain94@gmail.com>
Signed-off-by: Wolfstorm <xMakeItRain94@gmail.com>
@Wolfieheart
Copy link
Owner Author

Wolfieheart commented Jun 7, 2022 •
edited
Loading

1.19: Go for Release Checklist

  • Works on Spigot 1.19 (aka Enabled and Server Start isnt Halted)
  • Basic Function Works
  • Gravity Toggle Works
  • Toggle Arms Works
  • Enalbe/Disable Slots Works
  • Update Checking Works
  • Visibility Toggle Works
  • Equipment Works
  • Baseplate Works
  • Rotations
  • Copy/Paste Works
  • Towny Protection Works
  • WorldGuard Protection Works
  • GriefDefender Protection Works
  • GriefPrevention Protection Works
  • PlotSquared Protection Works
  • Release Published on Github
  • Release on SpigotMC

1.19 Fixes done during/after testing

  • Fix Give Messages
  • Fix Build not reporting the right version number
  • Debug not working as intended?
  • [ ]

@Wolfieheart
[CORE] Fix to remove the Additional Message if Give Fails
b631003 
Signed-off-by: Wolfieheart <xMakeItRain94@gmail.com>
Signed-off-by: Wolfstorm <xMakeItRain94@gmail.com>
@Wolfieheart
[CORE] POM Builds still 1.19.x-35 instead of 1.19-35
81e5e6a 
Signed-off-by: Wolfieheart <xMakeItRain94@gmail.com>
Signed-off-by: Wolfstorm <xMakeItRain94@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 7, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

0.0% 0.0% Coverage
0.9% 0.9% Duplication

@Wolfieheart
Copy link
Owner Author

Wolfieheart commented Jun 13, 2022 •
edited
Loading

Sorry for the delays/lack of progress regarding this. I should have already released this but I am in the middle of a Windows Reinstall Procedure and everything inbetween.

TLDR: My Windows Install decided to up and break after I took a clone and I am in the progress of manually reverting after the clone failed to reapply. After Reinstalling and trying to xCopy the user profile, Windows decided to hate the Registry and break that as well (2 days of work gone in an instant -.-) . Which is why I am going down the manual route here.

I will try to get back on track soon and I am super super sorry for the long delays. The previous release should also work fine on 1.19 for now, please let me know if this is not the case.

@Wolfieheart
Copy link
Owner Author

NOTE: Investigate #80 and Merge in #79

@Wolfieheart Wolfieheart mentioned this pull request Jun 13, 2022
Closed
2 tasks
@Wolfieheart
Copy link
Owner Author

Also add in GriefDefender Protection - #81

@Wolfieheart
Copy link
Owner Author

Status Update on ASE-1.19:

1.19 is now on general availability, and apparently ASE1.18.2-34.2 seems to be working on 1.19 which is a win. Please keep using that until I get a proper 1.19 build.

PC is currently at the stage where I am reinstalling programs in Batches -> I had ALOT of stuff. Currently I just reupgraded back to Windows 11 after a CPU replacement and I am still only half way with everything. I have the rest of my Programs and games to reinstall and set back up (currently at Letter G. Doing 3 groups of letters at a time and copying over my AppData as I go).

Thank you all for being patient and understanding the situation. I promise to get this out ASAP once everything is back in working order, this was not intentional or planned and threw a huge spanner into the works.

Kr,
Wolfie

@Wolfieheart
[CORE] Bump PS to 6.9.0
6fdb371 
Signed-off-by: Wolfieheart <xMakeItRain94@gmail.com>
Signed-off-by: xMakeItRain94@gmail.com <ParamoreFan1994$>
renovate bot and others added 4 commits June 18, 2022 16:36
@renovate @Wolfieheart
Update dependency com.palmergames.bukkit.towny:towny to v0.98.2.4 (#79)
63bed8a 
* [CI] Introduce Stale System

Signed-off-by: Wolfieheart <xMakeItRain94@gmail.com>
Signed-off-by: Wolfstorm <xMakeItRain94@gmail.com>

* [CI] Move Issue Templates over to this Repository

Signed-off-by: Wolfieheart <xMakeItRain94@gmail.com>
Signed-off-by: Wolfstorm <xMakeItRain94@gmail.com>

* Update dependency com.palmergames.bukkit.towny:towny to v0.98.2.4

Co-authored-by: Wolfstorm <xMakeItRain94@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@Wolfieheart
[CORE] Introduce GriefDefender Protection - Fixes #81
aeb231c 
Signed-off-by: xMakeItRain94@gmail.com <ParamoreFan1994$>
@Wolfieheart
[CORE] Add IgnoreProtections to Plugin.yml -> Basically I forgot to d…
857cf63 
…o this

Signed-off-by: Wolfieheart <xmakeitrain94@gmail.com>
@Wolfieheart
[CI SKIP] Add in Info RE: GriefPrevention no longer being active
900dae7 
Signed-off-by: Wolfieheart <xmakeitrain94@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 18, 2022

Please retry analysis of this Pull-Request directly on SonarCloud.

@Wolfieheart
[CORE] Fix issue with UpdateChecker post Relocation
1ef29c9 
Signed-off-by: Wolfieheart <xmakeitrain94@gmail.com>
@Wolfieheart
[CORE] Fix issue with UpdateChecker post Relocation
487e06c 
Signed-off-by: Wolfieheart <xmakeitrain94@gmail.com>
@Wolfieheart
[CORE] Fix Debug Output being active by default.
d78d3da 
Signed-off-by: Wolfieheart <xmakeitrain94@gmail.com>
@Wolfieheart
Copy link
Owner Author

TESTING COMPLETE:

Documentation Underway

@Wolfieheart
[CI] Update Towny to 0.98.2.6 - Closes #82
2e15373 
Signed-off-by: Wolfieheart <xmakeitrain94@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 22, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 16 Code Smells

0.0% 0.0% Coverage
0.8% 0.8% Duplication

@Wolfieheart Wolfieheart merged commit 51d476c into master Jun 22, 2022
@Wolfieheart Wolfieheart deleted the dev/1.18.2-35 branch June 22, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working dependencies Pull requests that update a dependency file enhancement New feature or request java Pull requests that update Java code P1: Extra Debug Required Extra Debug Effort Required P3: Awaiting Final Check Final check over - Issue Reporter required for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wolfieheart @Toldoven