Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated support for ISearchableObjectType #5457

Open
wants to merge 1 commit into
base: 6.2
Choose a base branch
from
Open

Remove deprecated support for ISearchableObjectType #5457

wants to merge 1 commit into from

Conversation

BurntimeX
Copy link
Member

No description provided.

@BurntimeX BurntimeX requested a review from TimWolla April 26, 2023 15:09
TimWolla
TimWolla reviewed Apr 27, 2023
View reviewed changes
Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't meaningfully comment on this, because I didn't really follow the search changes in 5.5. The diff looks not obviously wrong, but that might not mean much.

@BurntimeX
Copy link
Member Author

This should possibly be postponed to 6.1 or later, depending on how far the migration to "ISearchProvider" has already been completed by third-party developers.

@dtdesign dtdesign changed the base branch from master to 6.2 October 15, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimWolla TimWolla TimWolla left review comments

Assignees
No one assigned
Labels
None yet
Projects
WoltLab Suite 7.0
Status: Minor Task
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BurntimeX @TimWolla