Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add image resize support in CKEditor #5588

Merged
merged 6 commits into from
Jul 17, 2023
Merged

Add image resize support in CKEditor #5588

merged 6 commits into from
Jul 17, 2023

Conversation

dtdesign
Copy link
Member

n/t

@dtdesign dtdesign marked this pull request as ready for review July 17, 2023 15:34
TimWolla
TimWolla reviewed Jul 17, 2023
View reviewed changes
Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I can review this meaningfully. Doesn't look obviously wrong to me.

wcfsetup/install/files/lib/system/html/input/node/HtmlInputNodeImg.class.php Show resolved Hide resolved
@dtdesign
Copy link
Member Author

dtdesign commented Jul 17, 2023 •
edited
Loading

Thanks, but apart from obvious errors there is not a lot to look for. I have tested these changes during development and a lot of it is workaround the quirks of HTMLPurifier and extending the totally not already overloaded attach BBCode.

@dtdesign dtdesign merged commit 80db711 into master Jul 17, 2023
9 checks passed
@dtdesign dtdesign deleted the ckeditor-image-resize branch July 17, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimWolla TimWolla TimWolla left review comments

Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtdesign @TimWolla