Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use file processor for user avatar #6051

Draft
wants to merge 59 commits into
base: file-upload-image-crop
Choose a base branch
from
Draft

Use file processor for user avatar #6051

wants to merge 59 commits into from

Conversation

Cyperghost
Copy link
Contributor

@Cyperghost Cyperghost commented Nov 8, 2024 •
edited
Loading

Required #6047
See #5723

TODO

  • Use a different position to access the avatar management?
  • Does the page have to be reloaded after changing the avatar or can all avatars be changed live?
  • Move old avatar images via the UserRebuildDataWorker to the new file system
  • Renew or remove wcf\system\importer\UserAvatarImporter
  • Change the base branch to 6.2 after File processor image cropping #6047 has been merged
  • Add to Docs
    • JS WCF.User.Avatar.Upload removed
    • JS WCF.User.Avatar removed
    • PHP wcf\data\user\UserProfileAction::setAvatar() removed
    • PHP wcf\form\AvatarEditForm removed
    • PHP wcf\system\upload\AvatarUploadFileSaveStrategy removed
    • PHP wcf\system\upload\AvatarUploadFileValidationStrategy removed
    • PHP wcf\system\importer\UserAvatarImporter removed
    • PHP wcf\data\user\avatar\UserAvatar deprecated
    • PHP wcf\data\user\avatar\UserAvatarAction deprecated
    • PHP wcf\data\user\avatar\UserAvatarEditor deprecated
    • PHP wcf\data\user\avatar\UserAvatarList deprecated

@Cyperghost
Add basic file processor for avatar
afb055f
@Cyperghost
Add wcf1_user.avatarFileID column
882f7a9
@Cyperghost
Add session variable so that the user can delete the previous avatar
782ceb5
@Cyperghost
Add a new user menu item to manage the avatar
86805f9
@Cyperghost
Add dialog to edit the avatar file id
e027ed5
@Cyperghost
Add a command to set the avatar from a user
2df6b89
@Cyperghost
Support File in AvatarDecorator as avatar object
dfe7e6e
@Cyperghost
Remove old AvatarEditForm
4e8a4f6
@Cyperghost
Load user avatar on UserListPage
6d92aa3
@Cyperghost
Use CloseOverlay to close the user menu
74843d4
@Cyperghost
WCF.User.Avatar and WCF.User.Avatar.Upload are no longer used
2897de9
@Cyperghost
Avatar is now no longer saved in UserEditForm
d785e06 
Use `File` as user avatar
@Cyperghost
Do not reload the page in the ACP when editing the user after his ava…
27faeb7 
…tar has been changed
@Cyperghost
Delete old avatar file only if it is set
be50736
@Cyperghost
Deprecated UserAvatar
8eaed86
@Cyperghost
Move the old user avatar to the new file storage in the `UserRebuildD…
16d278a 
…ataWorker`.
@Cyperghost
Add new constant for the size of the avatar images in `UserAvatarFile…
1d15c2b 
…Processor`
@Cyperghost
Remove unused function UserAvatarAction::validateUpload() and `User…
1991832 
…AvatarAction::upload()`
@Cyperghost Cyperghost requested a review from dtdesign November 8, 2024 09:01
@Cyperghost Cyperghost mentioned this pull request Nov 18, 2024
Open
@BurntimeX BurntimeX mentioned this pull request Nov 19, 2024
Open
59 tasks
@dtdesign
Copy link
Member

@Cyperghost You also need to include the migration of the avatars as part of the UserRebuildDataWorker in your todo list.

Cyperghost and others added 20 commits November 27, 2024 08:43
@Cyperghost @dtdesign
Apply suggestions from code review
2cff601 
Co-authored-by: Alexander Ebert <ebert@woltlab.com>
@Cyperghost
Run tsc
4ad4afc
@Cyperghost
Check if objectIDs is empty
b3289a9
@Cyperghost
Check whether the user is in the accessible user groups
91e657f
@Cyperghost
Avatar size may also be 256x256 and not only a maximum of 128x128
eee7fb8
@Cyperghost
Merge branch 'file-upload-image-crop' into avatar-file-processor
3f16df7 
# Conflicts:
#	com.woltlab.wcf/templateDelete.xml
#	ts/WoltLabSuite/Core/Bootstrap.ts
#	wcfsetup/install/files/js/WoltLabSuite/Core/Bootstrap.js
@Cyperghost
Run tsc
0eb36d5
@Cyperghost
Merge branch 'file-upload-image-crop' into avatar-file-processor
41f636d 
# Conflicts:
#	wcfsetup/install/files/lib/data/attachment/AttachmentList.class.php
@Cyperghost
Add foreign key for wcf1_user.avatarFileID to wcf1_file.fileID
043b3fc
@Cyperghost
Merge branch 'file-upload-image-crop' into avatar-file-processor
5265f0a
@Cyperghost
createExact renamed to forExact
662416c
@Cyperghost
Merge branch 'file-upload-image-crop' into avatar-file-processor
8e2734d
@Cyperghost
Merge branch 'file-upload-image-crop' into avatar-file-processor
5f9a322
@Cyperghost
Merge branch 'file-upload-image-crop' into avatar-file-processor
f90b328 
# Conflicts:
#	com.woltlab.wcf/templates/user.tpl
#	wcfsetup/install/files/lib/data/attachment/Attachment.class.php
#	wcfsetup/install/lang/de.xml
#	wcfsetup/install/lang/en.xml
@Cyperghost
Use the user profile header template
e378fed
@Cyperghost
Use File::getFullSizeImageSource() instead of File::getLink()
ea529be
@Cyperghost
Add simpleReplace and hideDeleteButton to the `FileProcessorFormF…
70871a7 
…ield`
@Cyperghost
Display thumbnail size by file processor
8705964
@Cyperghost
Merge branch 'file-upload-image-crop' into avatar-file-processor
a44bea3 
# Conflicts:
#	ts/WoltLabSuite/Core/Component/Image/Cropper.ts
#	wcfsetup/install/files/js/WoltLabSuite/Core/Component/Image/Cropper.js
@Cyperghost
Unset uploadResolve
001ac17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtdesign dtdesign dtdesign requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cyperghost @dtdesign