Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remap_depot: fix loading of remap_depot preference #141

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

philipl
Copy link
Contributor

@philipl philipl commented Apr 20, 2024

Without this, the preference doesn't take affect.

@DoctorPresto
Copy link
Contributor

as mentioned on discord, we should move shared properties to the shared property group and then call them from there. Just need to pass the bool from the property group to the import function instead of self.remap_depot or operator.remap_depot

Feel free to ping me if you need any help with this

Grab it from the shared properties.
@DoctorPresto
Copy link
Contributor

Lgtm

@DoctorPresto DoctorPresto merged commit 571261c into WolvenKit:main Apr 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants