3.0: Composer: set the new requirements for WPCS #1905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the minimum required PHPCS version to `3.5.0`.
jrfnl
force-pushed
the
3.0/update-requirements
branch
3 times, most recently
from
ca60b4c
to
8557f4e
Compare
Composer:
* Add PHPCSUtils and PHPCSExtra as dependencies.
* Remove the DealerDirect plugin from `require-dev` as well as from `suggests` as it comes with PHPCSUtils/PHPCSExtra automatically and not having it here may prevent conflicts with allowed versions in the future.
Travis:
* Alias PHPCS 4.x to `3.9.99` to allow testing with the dependencies before PHPCS 4.x is officially supported by them.
* When testing with PHPCS 4.x, we need `--prefer-source` as otherwise the test files we use from PHPCS itself won't be included.
The way I've implemented this uses a [new feature](composer/composer#6301) which is available since Composer 1.10.0 to selectively download from source.
This prevents *all* packages being downloaded from source for the PHPCS `4.x` build, which would slow down the build and negate the Travis caching.
Note: the install/upgrade instructions in the Readme and other documentation will be addressed in a separate PR late in the 3.0 cycle, so as not to confuse people using the latest release, while 3.0.0 development is ongoing.
jrfnl
force-pushed
the
3.0/update-requirements
branch
from
8557f4e
to
f73d151
Compare
dingo-d
approved these changes
Jun 30, 2020
19 tasks
GaryJones
approved these changes
Jun 30, 2020
This was referenced Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Composer/Travis: change the minimum PHPCS version
Update the minimum required PHPCS version to
3.5.0.Composer: add PHPCSUtils and PHPCSExtra as dependencies
Composer:
require-devas well as fromsuggestsas it comes with PHPCSUtils/PHPCSExtra automatically and not having it here may prevent conflicts with allowed versions in the future.Travis:
3.9.99to allow testing with the dependencies before PHPCS 4.x is officially supported by them.--prefer-sourceas otherwise the test files we use from PHPCS itself won't be included.The way I've implemented this uses a new feature which is available since Composer 1.10.0 to selectively download from source.
This prevents all packages being downloaded from source for the PHPCS
4.xbuild, which would slow down the build and negate the Travis caching.Note: the install/upgrade instructions in the Readme and other documentation will be addressed in a separate PR late in the 3.0 cycle, so as not to confuse people using the latest release, while 3.0.0 development is ongoing.