Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0: Replace the WordPress.WhiteSpace.DisallowInlineTabs sniff #1912

Merged
merged 1 commit into from
Jul 6, 2020

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Jun 30, 2020

... with a similar sniff as merged upstream in PHPCSExtra as Universal.WhiteSpace.DisallowInlineTabs.

The upstream sniff:

  • Includes sniffing out inline tabs in // and /* */ style comments which the original sniff did not.
  • Will also examine files which only use short open echo PHP tags, while the original sniff did not.
  • Has a more advanced tab replacement in the fixer.

Ref: PHPCSStandards/PHPCSExtra#43

... with a similar sniff as merged upstream in PHPCSExtra as `Universal.WhiteSpace.DisallowInlineTabs`.

The upstream sniff includes sniffing out inline tabs in `//` and `/* */` style comments which the original sniff did not.
@GaryJones GaryJones merged commit 7e27d47 into develop Jul 6, 2020
@GaryJones GaryJones deleted the 3.0/replace-disallowinlinetabs-sniff branch July 6, 2020 13:28
@jrfnl jrfnl mentioned this pull request May 17, 2022
61 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants