Move unslashing-only functions related functionality to dedicated UnslashingFunctionsHelper
#2263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…slashingFunctionsHelper` The unslashing function list is only used by a small set of sniffs, so are better placed in a dedicated class. The `$unslashingFunctions` property has also been made `private static`. Checking whether or not something is an unslashing function should now be done by calling the `UnslashingFunctionsHelper::is_unslashing_function()` method. Includes removing a `@internal` comment from the `Sniff` class docblock as it is now redundant. Related to 1465
dingo-d
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unslashing function list is only used by a small set of sniffs, so are better placed in a dedicated class.
The
$unslashingFunctionsproperty has also been madeprivate static.Checking whether or not something is an unslashing function should now be done by calling the
UnslashingFunctionsHelper::is_unslashing_function()method.Includes removing a
@internalcomment from theSniffclass docblock as it is now redundant.Related to #1465