Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Update PHPCompatibilityWP version recommendation to 7.2 #2471

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

johnjago
Copy link

@johnjago johnjago commented Aug 6, 2024

As of WordPress 6.6, released on 16 July 2024, WordPress no longer supports PHP 7.0 and 7.1, so I’ve updated the recommended testVersion for PHPCompatibilityWP to be 7.2 in the README.

References:

@jrfnl
Copy link
Member

jrfnl commented Aug 6, 2024

I'm in two minds about this change. For plugins/themes, WPCS, by default, presumes support for the last three versions of WP Core and two of those do not have a minimum supported version of PHP 7.2 yet.

At the same time, the phrasing in the README says "the same PHP versions as WordPress Core supports", so leaving that recommendation at PHP 7.0 is not correct either.

Also note that any update like this should probably also update the phpcs.xml.dist.sample file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants