Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port ZipStreamReader from adamziel/wxr-normalize #116

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

adamziel
Copy link
Collaborator

This new ZipStreamReader opens its own file handles which means it can be paused, resumed, and is more reliable. The original implementation was built as a part of adamziel/wxr-normalize#1

This is all new code so there are no testing instructions. Eventually this implementation will replace the existing ZipStreamReader.

This new ZipStreamReader opens its own file handles which means
it can be paused, resumed, and is more reliable. The original
implementation was built as a part of adamziel/wxr-normalize#1

This is all new code so there are no testing instructions. Eventually
this implementation will replace the existing ZipStreamReader.
@adamziel adamziel added the enhancement New feature or request label Oct 30, 2024
@adamziel
Copy link
Collaborator Author

The failing tests seem to be also an issue with phpunit setup. I'll go ahead and merge anyway.

@adamziel adamziel merged commit df3bb1a into trunk Oct 30, 2024
12 of 21 checks passed
@adamziel adamziel deleted the new-zip-stream-reader branch October 30, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant