Create block: Add check for minimum system requirements (#20398)

* Create block: Add check for minimum system requirements Added error message when minimum system requirements not met. Corrected the minimum `npm` version required to align with `@wordpress/scripts` package used internally. * Update CHANGELOG.md
WordPress · Feb 24, 2020 · 1e26a8f · 1e26a8f
1 parent bef4179
commit 1e26a8f
Show file tree

Hide file tree

Showing 6 changed files with 37 additions and 17 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/create-block/CHANGELOG.md b/packages/create-block/CHANGELOG.md
@@ -1,5 +1,10 @@
 ## Master
 
+### Bug Fixes
+
+- Added error message when minimum system requirements not met ([#20398](https://github.com/WordPress/gutenberg/pull/20398/)).
+- Corrected the minimum `npm` version required to align with `@wordpress/scripts` package used internally ([#20398](https://github.com/WordPress/gutenberg/pull/20398/)).
+
 ## 0.8.0 (2020-02-21)
 
 ### New Features

diff --git a/packages/create-block/README.md b/packages/create-block/README.md
@@ -19,7 +19,7 @@ You just need to provide the `slug` which is the target location for scaffolded
   $ npm start
   ```
 
-  _(requires `node` version `10.0.0` or above, and `npm` version `6.1.0` or above)_
+  _(requires `node` version `10.0.0` or above, and `npm` version `6.9.0` or above)_
 
 You don’t need to install or configure tools like [webpack](https://webpack.js.org), [Babel](https://babeljs.io) or [ESLint](https://eslint.org) yourself. They are preconfigured and hidden so that you can focus on the code.
 

diff --git a/packages/create-block/lib/index.js b/packages/create-block/lib/index.js
@@ -1,9 +1,11 @@
 /**
  * External dependencies
  */
+const { command } = require( 'execa' );
 const program = require( 'commander' );
 const inquirer = require( 'inquirer' );
 const { startCase } = require( 'lodash' );
+const { join } = require( 'path' );
 
 /**
  * Internal dependencies
@@ -14,6 +16,19 @@ const { version } = require( '../package.json' );
 const scaffold = require( './scaffold' );
 const { getDefaultValues, getPrompts } = require( './templates' );
 
+async function checkSystemRequirements() {
+	try {
+		await command( 'check-node-version --package', {
+			cwd: join( __dirname, '..' ),
+		} );
+	} catch ( error ) {
+		log.error( 'Minimum system requirements not met!' );
+		log.error( error.stderr );
+		log.info( error.stdout );
+		process.exit( error.exitCode );
+	}
+}
+
 const commandName = `wp-create-block`;
 program
 	.name( commandName )
@@ -31,6 +46,7 @@ program
 		'esnext'
 	)
 	.action( async ( slug, { template } ) => {
+		await checkSystemRequirements();
 		try {
 			const defaultValues = getDefaultValues( template );
 			if ( slug ) {
@@ -50,21 +66,18 @@ program
 			}
 		} catch ( error ) {
 			if ( error instanceof CLIError ) {
-				log.info( '' );
 				log.error( error.message );
 				process.exit( 1 );
 			} else {
 				throw error;
 			}
 		}
-	} );
-
-program.on( '--help', function() {
-	log.info( '' );
-	log.info( 'Examples:' );
-	log.info( `  $ ${ commandName }` );
-	log.info( `  $ ${ commandName } todo-list` );
-	log.info( `  $ ${ commandName } --template es5 todo-list` );
-} );
-
-program.parse( process.argv );
+	} )
+	.on( '--help', function() {
+		log.info( '' );
+		log.info( 'Examples:' );
+		log.info( `  $ ${ commandName }` );
+		log.info( `  $ ${ commandName } todo-list` );
+		log.info( `  $ ${ commandName } --template es5 todo-list` );
+	} )
+	.parse( process.argv );
diff --git a/packages/create-block/lib/templates.js b/packages/create-block/lib/templates.js
@@ -1,7 +1,7 @@
 /**
  * Internal dependencies
  */
-const CliError = require( './cli-error' );
+const CLIError = require( './cli-error' );
 const prompts = require( './prompts' );
 
 const namespace = 'create-block';
@@ -60,7 +60,7 @@ const templates = {
 
 const getTemplate = ( templateName ) => {
 	if ( ! templates[ templateName ] ) {
-		throw new CliError(
+		throw new CLIError(
 			`Invalid template type name. Allowed values: ${ Object.keys(
 				templates
 			).join( ', ' ) }.`

diff --git a/packages/create-block/package.json b/packages/create-block/package.json
@@ -19,8 +19,8 @@
 		"url": "https://github.com/WordPress/gutenberg/issues"
 	},
 	"engines": {
-		"node": ">=10.0",
-		"npm": ">=6.1"
+		"node": ">=10",
+		"npm": ">=6.9"
 	},
 	"files": [
 		"lib"
@@ -31,6 +31,7 @@
 	},
 	"dependencies": {
 		"chalk": "^2.4.2",
+		"check-node-version": "^3.1.1",
 		"commander": "^4.1.0",
 		"execa": "^4.0.0",
 		"inquirer": "^7.0.3",