Skip to content

Commit

Permalink
Revert "Block Library: Fix incorrect attributes definitions #36140"
Browse files Browse the repository at this point in the history
The `templateLock` attribute is mixed between boolean and string. Setting the type as string introduces an regression that will remove `false` on save.

The original PR (#36140) tried to fix a validation issue reported in #35902

The schema error is incorrect. The attribute definition is required to have either a `type` or an `enum`.
  • Loading branch information
Petter Walbø Johnsgård committed Nov 5, 2021
1 parent da60600 commit 2726500
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 3 deletions.
1 change: 0 additions & 1 deletion packages/block-library/src/column/block.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
"type": "array"
},
"templateLock": {
"type": "string",
"enum": [ "all", "insert", false ]
}
},
Expand Down
1 change: 0 additions & 1 deletion packages/block-library/src/cover/block.json
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@
"type": "array"
},
"templateLock": {
"type": "string",
"enum": [ "all", "insert", false ]
}
},
Expand Down
1 change: 0 additions & 1 deletion packages/block-library/src/group/block.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
"default": "div"
},
"templateLock": {
"type": "string",
"enum": [ "all", "insert", false ]
}
},
Expand Down

0 comments on commit 2726500

Please sign in to comment.