List Block: Do not split on line breaks when multiple blocks are tran…

…sformed (#13832)
WordPress · Mar 6, 2019 · 29603e9 · 29603e9
1 parent 3788066
commit 29603e9
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 3 deletions.
diff --git a/packages/block-library/src/list/index.js b/packages/block-library/src/list/index.js
@@ -73,9 +73,17 @@ export const settings = {
 				transform: ( blockAttributes ) => {
 					return createBlock( 'core/list', {
 						values: toHTMLString( {
-							value: join( blockAttributes.map( ( { content } ) =>
-								replace( create( { html: content } ), /\n/g, LINE_SEPARATOR )
-							), LINE_SEPARATOR ),
+							value: join( blockAttributes.map( ( { content } ) => {
+								const value = create( { html: content } );
+
+								if ( blockAttributes.length > 1 ) {
+									return value;
+								}
+
+								// When converting only one block, transform
+								// every line to a list item.
+								return replace( value, /\n/g, LINE_SEPARATOR );
+							} ), LINE_SEPARATOR ),
 							multilineTag: 'li',
 						} ),
 					} );

diff --git a/packages/e2e-tests/specs/blocks/__snapshots__/list.test.js.snap b/packages/e2e-tests/specs/blocks/__snapshots__/list.test.js.snap
@@ -156,6 +156,12 @@ exports[`List should insert a line break on shift+enter in a non trailing list i
 <!-- /wp:list -->"
 `;
 
+exports[`List should not transform lines in block when transforming multiple blocks 1`] = `
+"<!-- wp:list -->
+<ul><li>one<br>...</li><li>two</li></ul>
+<!-- /wp:list -->"
+`;
+
 exports[`List should outdent with children 1`] = `
 "<!-- wp:list -->
 <ul><li>a<ul><li>b<ul><li>c</li></ul></li></ul></li></ul>

diff --git a/packages/e2e-tests/specs/blocks/list.test.js b/packages/e2e-tests/specs/blocks/list.test.js
@@ -95,6 +95,21 @@ describe( 'List', () => {
 		expect( await getEditedPostContent() ).toMatchSnapshot();
 	} );
 
+	it( 'should not transform lines in block when transforming multiple blocks', async () => {
+		await clickBlockAppender();
+		await page.keyboard.type( 'one' );
+		await pressKeyWithModifier( 'shift', 'Enter' );
+		await page.keyboard.type( '...' );
+		await page.keyboard.press( 'Enter' );
+		await page.keyboard.type( 'two' );
+		await page.keyboard.down( 'Shift' );
+		await page.click( '[data-type="core/paragraph"]' );
+		await page.keyboard.up( 'Shift' );
+		await transformBlockTo( 'List' );
+
+		expect( await getEditedPostContent() ).toMatchSnapshot();
+	} );
+
 	it( 'can be converted to paragraphs', async () => {
 		await insertBlock( 'List' );
 		await page.keyboard.type( 'one' );