Blocks: Try to fix rerender issue for custom class name

WordPress · Nov 16, 2017 · 3d54d33 · 3d54d33
1 parent 74b8cfa
commit 3d54d33
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 17 deletions.
diff --git a/blocks/block-edit/index.js b/blocks/block-edit/index.js
@@ -15,12 +15,10 @@ function BlockEdit( props ) {
 	// `edit` and `save` are functions or components describing the markup
 	// with which a block is displayed. If `blockType` is valid, assign
 	// them preferencially as the render value for the block.
-	let Edit;
-	if ( blockType ) {
-		Edit = blockType.edit || blockType.save;
-	}
+	const Edit = blockType.edit || blockType.save;
+	Edit.displayName = 'Edit';
 
-	return applyFilters( 'BlockEdit', <Edit { ...editProps } />, props );
+	return applyFilters( 'BlockEdit', <Edit key="edit" { ...editProps } />, props );
 }
 
 export default BlockEdit;
diff --git a/blocks/hooks/anchor.js b/blocks/hooks/anchor.js
@@ -6,6 +6,7 @@ import { assign } from 'lodash';
 /**
  * WordPress dependencies
  */
+import { concatChildren } from '@wordpress/element';
 import { __ } from '@wordpress/i18n';
 
 /**
@@ -54,9 +55,9 @@ export function addAttribute( settings ) {
  */
 export function addInspectorControl( element, props ) {
 	if ( hasBlockSupport( props.name, 'anchor' ) && props.focus ) {
-		element = [
+		element = concatChildren(
 			element,
-			<InspectorControls key="inspector-anchor">
+			<InspectorControls>
 				<InspectorControls.TextControl
 					label={ __( 'HTML Anchor' ) }
 					help={ __( 'Anchors lets you link directly to a section on a page.' ) }
@@ -68,8 +69,8 @@ export function addInspectorControl( element, props ) {
 							anchor: nextValue,
 						} );
 					} } />
-			</InspectorControls>,
-		];
+			</InspectorControls>
+		);
 	}
 
 	return element;

diff --git a/blocks/hooks/custom-class-name.js b/blocks/hooks/custom-class-name.js
@@ -7,6 +7,7 @@ import classnames from 'classnames';
 /**
  * WordPress dependencies
  */
+import { concatChildren } from '@wordpress/element';
 import { __ } from '@wordpress/i18n';
 
 /**
@@ -45,9 +46,9 @@ export function addAttribute( settings ) {
  */
 export function addInspectorControl( element, props ) {
 	if ( hasBlockSupport( props.name, 'customClassName', true ) && props.focus ) {
-		element = [
+		element = concatChildren(
 			element,
-			<InspectorControls key="inspector-custom-classname">
+			<InspectorControls force>
 				<InspectorControls.TextControl
 					label={ __( 'Additional CSS Class' ) }
 					value={ props.attributes.className || '' }
@@ -57,8 +58,8 @@ export function addInspectorControl( element, props ) {
 						} );
 					} }
 				/>
-			</InspectorControls>,
-		];
+			</InspectorControls>
+		);
 	}
 
 	return element;

diff --git a/blocks/inspector-controls/index.js b/blocks/inspector-controls/index.js
@@ -15,9 +15,9 @@ import TextControl from './text-control';
 import TextareaControl from './textarea-control';
 import ToggleControl from './toggle-control';
 
-export default function InspectorControls( { children } ) {
+export default function InspectorControls( { force = false, children } ) {
 	return (
-		<Fill name="Inspector.Controls">
+		<Fill name="Inspector.Controls" force={ force }>
 			{ children }
 		</Fill>
 	);

diff --git a/components/slot-fill/fill.js b/components/slot-fill/fill.js
@@ -27,13 +27,13 @@ class Fill extends Component {
 	}
 
 	componentWillReceiveProps( nextProps ) {
-		const { name } = nextProps;
+		const { name, force } = nextProps;
 		const {
 			unregisterFill = noop,
 			registerFill = noop,
 		} = this.context;
 
-		if ( this.props.name !== name ) {
+		if ( this.props.name !== name || force ) {
 			unregisterFill( this.props.name, this );
 			registerFill( name, this );
 		}