Fix for #11663 (#12728)

* Fixed Deleting an HTML Anchor attribute leaves an empty HTML id attribute * Fixed Deleting an HTML Anchor attribute leaves an empty
WordPress · Dec 10, 2018 · 47736a4 · 47736a4
1 parent b44a2f1
commit 47736a4
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/packages/editor/src/hooks/anchor.js b/packages/editor/src/hooks/anchor.js
@@ -98,7 +98,7 @@ export const withInspectorControl = createHigherOrderComponent( ( BlockEdit ) =>
  */
 export function addSaveProps( extraProps, blockType, attributes ) {
 	if ( hasBlockSupport( blockType, 'anchor' ) ) {
-		extraProps.id = attributes.anchor;
+		extraProps.id = attributes.anchor === '' ? null : attributes.anchor;
 	}
 
 	return extraProps;

diff --git a/packages/editor/src/hooks/test/anchor.js b/packages/editor/src/hooks/test/anchor.js
@@ -62,5 +62,17 @@ describe( 'anchor', () => {
 
 			expect( extraProps.id ).toBe( 'foo' );
 		} );
+
+		it( 'should remove an anchor attribute ID when feild is cleared', () => {
+			const attributes = { anchor: '' };
+			const extraProps = getSaveContentExtraProps( {}, {
+				...blockSettings,
+				supports: {
+					anchor: true,
+				},
+			}, attributes );
+
+			expect( extraProps.id ).toBe( null );
+		} );
 	} );
 } );