Skip to content

Commit

Permalink
Revert "Build: remove global install of latest npm since we want to u…
Browse files Browse the repository at this point in the history
…se the paired node/npm version (#17134)"

This reverts commit 0b4d9c8.
  • Loading branch information
gwwar authored Aug 23, 2019
1 parent bd2604f commit 4800b7c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ branches:
- master

before_install:
- nvm install
- nvm install --latest-npm

env: PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true

Expand Down
3 changes: 3 additions & 0 deletions bin/install-node-nvm.sh
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,9 @@ fi
echo -e $(status_message "Installing and updating NPM packages..." )
npm install

# Make sure npm is up-to-date
npm install npm -g

# There was a bug in NPM that caused changes in package-lock.json. Handle that.
if [ "$TRAVIS" != "true" ] && ! git diff --no-ext-diff --exit-code package-lock.json >/dev/null; then
if ask "$(warning_message "Your package-lock.json changed, which may mean there's an issue with your NPM cache. Would you like to try and automatically clean it up?" )" N 10; then
Expand Down

0 comments on commit 4800b7c

Please sign in to comment.