Skip to content

Commit

Permalink
Revert "Add API for Logging User Events in gutenberg-mobile and iOS"
Browse files Browse the repository at this point in the history
This reverts commit d6f0c5b.
  • Loading branch information
chipsnyder committed Feb 19, 2020
1 parent 8627283 commit 4ccf920
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 26 deletions.
2 changes: 1 addition & 1 deletion gutenberg
Submodule gutenberg updated 77 files
+0 −17 .github/workflows/bundle-size.yml
+0 −77 docs/designers-developers/developers/block-api/block-registration.md
+1 −1 docs/designers-developers/developers/themes/README.md
+0 −1 lib/blocks.php
+1 −1 lib/template-loader.php
+0 −6 packages/block-editor/README.md
+23 −23 packages/block-editor/src/components/block-list/block.native.js
+0 −6 packages/block-editor/src/components/block-list/index.native.js
+0 −22 packages/block-editor/src/components/block-settings-menu-controls/README.md
+0 −43 packages/block-editor/src/components/block-settings-menu-controls/index.js
+13 −0 packages/block-editor/src/components/block-settings-menu/block-settings-menu-plugins-extension.js
+4 −4 packages/block-editor/src/components/block-settings-menu/index.js
+0 −2 packages/block-editor/src/components/color-palette/test/__snapshots__/control.js.snap
+1 −7 packages/block-editor/src/components/default-block-appender/index.native.js
+1 −1 packages/block-editor/src/components/index.js
+3 −60 packages/block-editor/src/components/link-control/README.md
+68 −276 packages/block-editor/src/components/link-control/index.js
+0 −54 packages/block-editor/src/components/link-control/search-create-button.js
+42 −38 packages/block-editor/src/components/link-control/search-input.js
+1 −1 packages/block-editor/src/components/link-control/settings-drawer.js
+9 −53 packages/block-editor/src/components/link-control/style.scss
+1 −1 packages/block-editor/src/components/link-control/test/__snapshots__/index.js.snap
+2 −472 packages/block-editor/src/components/link-control/test/index.js
+0 −8 packages/block-editor/src/components/page-template-picker/picker.js
+0 −1 packages/block-editor/src/components/url-input/index.js
+1 −1 packages/block-editor/src/components/url-popover/README.md
+1 −1 packages/block-editor/src/components/url-popover/image-url-input-ui.js
+0 −1 packages/block-library/src/editor.scss
+0 −1 packages/block-library/src/heading/heading-toolbar.js
+0 −2 packages/block-library/src/index.js
+3 −30 packages/block-library/src/navigation-link/edit.js
+1 −5 packages/block-library/src/post-comments-form/index.php
+1 −14 packages/block-library/src/post-excerpt/block.json
+5 −103 packages/block-library/src/post-excerpt/edit.js
+0 −3 packages/block-library/src/post-excerpt/editor.scss
+2 −40 packages/block-library/src/post-excerpt/index.php
+0 −4 packages/block-library/src/post-featured-image/block.json
+0 −34 packages/block-library/src/post-featured-image/edit.js
+0 −21 packages/block-library/src/post-featured-image/index.js
+0 −32 packages/block-library/src/post-featured-image/index.php
+0 −1 packages/block-library/src/social-link/block.json
+1 −1 packages/block-library/src/social-links/index.js
+0 −4 packages/block-library/src/spacer/editor.scss
+1 −1 packages/blocks/src/api/registration.js
+2 −13 packages/components/src/circular-option-picker/index.js
+1 −1 packages/components/src/circular-option-picker/style.scss
+1 −11 packages/components/src/color-palette/index.js
+0 −39 packages/components/src/color-palette/test/__snapshots__/index.js.snap
+5 −11 packages/core-data/src/entity-provider.js
+1 −5 packages/e2e-tests/fixtures/blocks/core__latest-posts.json
+1 −5 packages/e2e-tests/fixtures/blocks/core__latest-posts__displayPostDate.json
+1 −1 packages/e2e-tests/fixtures/blocks/core__navigation.json
+1 −4 packages/e2e-tests/fixtures/blocks/core__post-excerpt.json
+0 −1 packages/e2e-tests/fixtures/blocks/core__post-featured-image.html
+0 −10 packages/e2e-tests/fixtures/blocks/core__post-featured-image.json
+0 −18 packages/e2e-tests/fixtures/blocks/core__post-featured-image.parsed.json
+0 −1 packages/e2e-tests/fixtures/blocks/core__post-featured-image.serialized.html
+5 −5 packages/e2e-tests/specs/editor/various/links.test.js
+5 −11 packages/e2e-tests/specs/experiments/__snapshots__/navigation.test.js.snap
+14 −141 packages/e2e-tests/specs/experiments/navigation.test.js
+40 −0 packages/edit-post/src/components/block-settings-menu/plugin-block-settings-menu-group.js
+8 −3 packages/edit-post/src/components/block-settings-menu/plugin-block-settings-menu-item.js
+9 −0 packages/edit-post/src/components/visual-editor/index.js
+3 −3 packages/editor/src/components/convert-to-group-buttons/index.js
+1 −1 packages/editor/src/components/post-title/index.native.js
+3 −3 packages/editor/src/components/reusable-blocks-buttons/index.js
+0 −1 packages/env/CHANGELOG.md
+0 −2 packages/env/README.md
+2 −27 packages/env/lib/config.js
+0 −13 packages/env/lib/env.js
+0 −66 packages/env/test/config.js
+1 −18 packages/format-library/src/image/index.js
+7 −26 packages/format-library/src/text-color/index.js
+4 −54 packages/icons/src/icon/stories/index.js
+2 −2 packages/media-utils/src/components/media-upload/index.js
+0 −6,307 storybook/test/__snapshots__/index.js.snap
+1 −1 test/integration/full-content/server-registered.json
8 changes: 0 additions & 8 deletions react-native-gutenberg-bridge/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@ export const mediaSources = {
siteMediaLibrary: 'SITE_MEDIA_LIBRARY',
};

export const userEvents = {
pageTemplateApplied: 'page_template_applied',
};

export const showMediaEditorButton = isIOS;

// Console polyfill from react-native
Expand Down Expand Up @@ -122,8 +118,4 @@ export function fetchRequest( path ) {
return RNReactNativeGutenbergBridge.fetchRequest( path );
}

export function logUserEvent( event, properties ) {
return RNReactNativeGutenbergBridge.logUserEvent( event, properties );
}

export default RNReactNativeGutenbergBridge;
10 changes: 0 additions & 10 deletions react-native-gutenberg-bridge/ios/GutenbergBridgeDelegate.swift
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,6 @@ extension RCTLogLevel {
}
}

public enum GutenbergUserEvent: String {
case pageTemplateApplied = "page_template_applied"
}

public protocol GutenbergBridgeDelegate: class {
/// Tells the delegate that Gutenberg had returned the requested HTML content.
/// You can request HTML content by calling `requestHTML()` on a Gutenberg bridge instance.
Expand Down Expand Up @@ -142,12 +138,6 @@ public protocol GutenbergBridgeDelegate: class {
/// Tells the delegate to display the media editor from a given URL
///
func gutenbergDidRequestMediaEditor(with mediaUrl: URL, callback: @escaping MediaPickerDidPickMediaCallback)


/// Tells the delegate that the editor needs to log a custom event
/// - Parameter event: The event key to be logged
/// - Parameter properties: Any relevant properties related to the event
func gutenbergLogUserEvent(_ event: GutenbergUserEvent, properties: [AnyHashable: Any])
}

// MARK: - Optional GutenbergBridgeDelegate methods
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,5 @@ @interface RCT_EXTERN_MODULE(RNReactNativeGutenbergBridge, NSObject)
RCT_EXTERN_METHOD(fetchRequest:(NSString *)path resolver:(RCTPromiseResolveBlock)resolve rejecter:(RCTPromiseRejectBlock)reject)
RCT_EXTERN_METHOD(requestImageFullscreenPreview:(NSString *)currentImageUrlString originalImageUrlString:(NSString *)originalImageUrlString)
RCT_EXTERN_METHOD(requestMediaEditor:(NSString *)mediaUrl callback:(RCTResponseSenderBlock)callback)
RCT_EXTERN_METHOD(logUserEvent:(NSString *)event properties:(NSDictionary *)properties)

@end
Original file line number Diff line number Diff line change
Expand Up @@ -224,12 +224,6 @@ public class RNReactNativeGutenbergBridge: RCTEventEmitter {
self.sendEvent(withName: name, body: body)
}
}

@objc
func logUserEvent(_ event: String, properties:[AnyHashable: Any]?) {
guard let event = GutenbergUserEvent(rawValue: event) else { return }
self.delegate?.gutenbergLogUserEvent(event, properties: properties ?? [:])
}
}

// MARK: - RCTBridgeModule delegate
Expand Down

0 comments on commit 4ccf920

Please sign in to comment.