[RNMobile] iOS Image block caption multiline fix (#16071)

* Add unit test to cover multiline rich-text onEnter appends br tag * Fix iOS issue where pressing Enter on image caption won't create a new line
WordPress · Jun 10, 2019 · 4d08cc5 · 4d08cc5
1 parent a5a3c08
commit 4d08cc5
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 1 deletion.
diff --git a/packages/block-editor/src/components/rich-text/index.native.js b/packages/block-editor/src/components/rich-text/index.native.js
@@ -365,7 +365,7 @@ export class RichText extends Component {
 				const insertedLineSeparator = { ...insertLineSeparator( currentRecord ) };
 				this.onFormatChange( insertedLineSeparator );
 			}
-		} else if ( event.shiftKey || ! this.onSplit ) {
+		} else if ( event.shiftKey || ! onSplit ) {
 			this.needsSelectionUpdate = true;
 			const insertedLineBreak = { ...insert( currentRecord, '\n' ) };
 			this.onFormatChange( insertedLineBreak );

diff --git a/packages/block-editor/src/components/rich-text/test/index.native.js b/packages/block-editor/src/components/rich-text/test/index.native.js
@@ -1,3 +1,8 @@
+/**
+ * External dependencies
+ */
+import { shallow } from 'enzyme';
+
 /**
  * Internal dependencies
  */
@@ -24,4 +29,28 @@ describe( 'RichText Native', () => {
 			expect( richText.willTrimSpaces( html ) ).toBe( false );
 		} );
 	} );
+
+	describe( 'Adds new line on Enter', () => {
+		let newValue;
+		const wrapper = shallow( <RichText 
+			rootTagsToEliminate={ [ 'p' ] }
+			value={ "" }
+			onChange={ ( value ) => {
+				newValue = value
+			} }
+			formatTypes={ [] }
+			onSelectionChange={ jest.fn() }
+		/> );
+
+		const event = {
+			nativeEvent: {
+				eventCount: 0,
+			}
+		};
+		wrapper.instance().onEnter(event);
+
+		it( ' Adds <br> tag to content after pressing Enter key', () => {
+			expect( newValue ).toEqual( "<br>" );
+		});
+	} );
 } );