Memoize useSelect callback function

Co-Authored-By: Zebulan Stanphill <zebulanstanphill@protonmail.com>
WordPress · Apr 6, 2020 · 6683673 · 6683673
1 parent 81d8cf6
commit 6683673
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/packages/block-editor/src/components/block-navigation/toolbar.js b/packages/block-editor/src/components/block-navigation/toolbar.js
@@ -13,8 +13,9 @@ import BlockActions from '../block-actions';
 import BlockMover from '../block-mover';
 
 export default function BlockNavigationToolbar() {
-	const blockClientIds = useSelect( ( select ) =>
-		select( 'core/block-editor' ).getSelectedBlockClientIds()
+	const blockClientIds = useSelect(
+		( select ) => select( 'core/block-editor' ).getSelectedBlockClientIds(),
+		[]
 	);
 
 	return (

diff --git a/packages/edit-navigation/src/components/menu-editor/navigation-structure-panel.js b/packages/edit-navigation/src/components/menu-editor/navigation-structure-panel.js
@@ -10,8 +10,9 @@ import { useDispatch, useSelect } from '@wordpress/data';
 import { __ } from '@wordpress/i18n';
 
 export default function NavigationStructurePanel( { blocks } ) {
-	const selectedBlockClientIds = useSelect( ( select ) =>
-		select( 'core/block-editor' ).getSelectedBlockClientIds()
+	const blockClientIds = useSelect(
+		( select ) => select( 'core/block-editor' ).getSelectedBlockClientIds(),
+		[]
 	);
 
 	const { selectBlock } = useDispatch( 'core/block-editor' );