Use untitled as fallback title when missing in listing latest-posts

Fixes #1990
WordPress · Jul 25, 2017 · 813af21 · 813af21
1 parent 11522a0
commit 813af21
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/blocks/library/latest-posts/index.js b/blocks/library/latest-posts/index.js
@@ -170,7 +170,7 @@ registerBlockType( 'core/latest-posts', {
 				>
 					{ latestPosts.map( ( post, i ) =>
 						<li key={ i }>
-							<a href={ post.link } target="_blank">{ post.title.rendered }</a>
+							<a href={ post.link } target="_blank">{ post.title.rendered.trim() || __( '(Untitled)' ) }</a>
 							{ displayPostDate && post.date_gmt &&
 								<time dateTime={ moment( post.date_gmt ).utc().format() } className={ `${ this.props.className }__post-date` }>
 									{ moment( post.date_gmt ).local().format( 'MMM DD h:mm A' ) }

diff --git a/lib/blocks/latest-posts.php b/lib/blocks/latest-posts.php
@@ -49,10 +49,14 @@ function gutenberg_render_block_core_latest_posts( $attributes ) {
 	foreach ( $recent_posts as $post ) {
 		$post_id = $post['ID'];
 
+		$title = get_the_title( $post_id );
+		if ( ! $title ) {
+			$title = __( '(Untitled)', 'gutenberg' );
+		}
 		$posts_content .= sprintf(
 			'<li><a href="%1$s">%2$s</a>',
 			esc_url( get_permalink( $post_id ) ),
-			esc_html( get_the_title( $post_id ) )
+			esc_html( $title )
 		);
 
 		if ( $attributes['displayPostDate'] ) {