Scripts: Add missing root flag to the default Eslint config (#13483)

* Scripts: Add missing root flag to the default Eslint config * scripts: Instruct ESLint to avoid config discovery in defaulting
WordPress · Mar 6, 2019 · a052b3f · a052b3f
1 parent 70f4a10
commit a052b3f
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/packages/scripts/CHANGELOG.md b/packages/scripts/CHANGELOG.md
@@ -5,6 +5,10 @@
 - Added support for `build` script ([#12837](https://github.com/WordPress/gutenberg/pull/12837))
 - Added support for `start` script ([#12837](https://github.com/WordPress/gutenberg/pull/12837))
 
+### Bug Fix
+
+- Avoid inheriting from ESLint configurations in ancestor directories when using the default configuration ([#13483](https://github.com/WordPress/gutenberg/pull/13483))
+
 ## 2.5.0 (2019-01-09)
 
 ### New Features

diff --git a/packages/scripts/config/.eslintrc.js b/packages/scripts/config/.eslintrc.js
@@ -1,3 +1,4 @@
 module.exports = {
+	root: true,
 	extends: [ 'plugin:@wordpress/eslint-plugin/recommended' ],
 };
diff --git a/packages/scripts/scripts/lint-js.js b/packages/scripts/scripts/lint-js.js
@@ -26,8 +26,11 @@ const hasLintConfig = hasCliArg( '-c' ) ||
 	hasProjectFile( '.eslintrc' ) ||
 	hasPackageProp( 'eslintConfig' );
 
+// When a configuration is not provided by the project, use from the default
+// provided with the scripts module. Instruct ESLint to avoid discovering via
+// the `--no-eslintrc` flag, as otherwise it will still merge with inherited.
 const config = ! hasLintConfig ?
-	[ '--config', fromConfigRoot( '.eslintrc.js' ) ] :
+	[ '--no-eslintrc', '--config', fromConfigRoot( '.eslintrc.js' ) ] :
 	[];
 
 const result = spawn(