Enhance template registration e2e tests to handle welcome dialog visi…

…bility (#68059)

* Enhance template registration e2e tests to handle welcome dialog visibility

Added logic to check for the visibility of the "Welcome to the editor" dialog within 2 seconds before attempting to close it.

* Replace `visitAdminPage( '/post-new.php' )` with `createNewPost()` and remove the updates to the second test

* Remove extra whitespace

* Replace `visitAdminPage` with `createNewPost()` in `themes can override registered templates` e2e test

Co-authored-by: michalczaplinski <czapla@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

test/e2e/specs/site-editor/template-registration.spec.js

@@ -100,8 +100,7 @@ test.describe( 'Block template registration', () => {
 		page,
 	} ) => {
 		// Create a post.
-		await admin.visitAdminPage( '/post-new.php' );
-		await page.getByLabel( 'Close', { exact: true } ).click();
+		await admin.createNewPost();
 		await editor.insertBlock( {
 			name: 'core/paragraph',
 			attributes: { content: 'User-created post.' },
@@ -128,7 +127,7 @@ test.describe( 'Block template registration', () => {
 		blockTemplateRegistrationUtils,
 	} ) => {
 		// Create a post.
-		await admin.visitAdminPage( '/post-new.php' );
+		await admin.createNewPost();
 		await editor.insertBlock( {
 			name: 'core/paragraph',
 			attributes: { content: 'User-created post.' },