Testing: Check markup for errors in visitAdminPage

packages/e2e-test-utils/src/has-php-error.js

@@ -0,0 +1,22 @@
+/**
+ * Regular expression matching a displayed PHP error within a markup string.
+ *
+ * @link https://github.com/php/php-src/blob/598175e/main/main.c#L1257-L1297
+ *
+ * @type RegExp
+ */
+const REGEXP_PHP_ERROR = /<b>(Fatal error|Recoverable fatal error|Warning|Parse error|Notice|Strict Standards|Deprecated|Unknown error)<\/b>/;
+
+/**
+ * Returns a promise resolving to a boolean reflecting whether a PHP notice is
+ * present anywhere within the document's markup. This requires the environment
+ * be configured to display errors.
+ *
+ * @link http://php.net/manual/en/function.error-reporting.php
+ *
+ * @return {Promise} Promise resolving to a boolean reflecting whether a PHP
+ *                   notice is present.
+ */
+export async function hasPHPError() {
+	return REGEXP_PHP_ERROR.test( await page.content() );
+}

packages/e2e-test-utils/src/index.js

@@ -21,14 +21,14 @@ export { getAvailableBlockTransforms } from './get-available-block-transforms';
 export { getBlockSetting } from './get-block-setting';
 export { getEditedPostContent } from './get-edited-post-content';
 export { hasBlockSwitcher } from './has-block-switcher';
+export { hasPHPError } from './has-php-error';
 export { insertBlock } from './insert-block';
 export { installPlugin } from './install-plugin';
 export { isCurrentURL } from './is-current-url';
 export { isInDefaultBlock } from './is-in-default-block';
 export { loginUser } from './login-user';
 export { observeFocusLoss } from './observe-focus-loss';
 export { openAllBlockInserterCategories } from './open-all-block-inserter-categories';
-export { observePageWarnings } from './observe-page-warnings';
 export { openDocumentSettingsSidebar } from './open-document-settings-sidebar';
 export { openGlobalBlockInserter } from './open-global-block-inserter';
 export { openPublishPanel } from './open-publish-panel';

packages/e2e-test-utils/src/visit-admin-page.js

@@ -9,6 +9,7 @@ import { join } from 'path';
 import { createURL } from './create-url';
 import { isCurrentURL } from './is-current-url';
 import { loginUser } from './login-user';
+import { hasPHPError } from './has-php-error';
 
 /**
  * Visits admin page; if user is not logged in then it logging in it first, then visits admin page.
@@ -25,4 +26,6 @@ export async function visitAdminPage( adminPath, query ) {
 		await loginUser();
 		await visitAdminPage( adminPath, query );
 	}
+
+	expect( await hasPHPError() ).toBe( false );
 }

packages/e2e-tests/config/setup-test-framework.js

@@ -10,7 +10,6 @@ import '@wordpress/jest-console';
 import {
 	clearLocalStorage,
 	enablePageDialogAccept,
-	observePageWarnings,
 	setBrowserViewport,
 	visitAdminPage,
 	activatePlugin,
@@ -156,7 +155,6 @@ beforeAll( async () => {
 	capturePageEventsForTearDown();
 	enablePageDialogAccept();
 	observeConsoleLogging();
-	observePageWarnings();
 
 	await trashExistingPosts();
 	await setupBrowser();