displayShortcut capitalizes provided key (e.g. Del instead of DEL)

WordPress · Jul 31, 2018 · ef530a9 · ef530a9
1 parent faea1dc
commit ef530a9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/keycodes/src/index.js b/packages/keycodes/src/index.js
@@ -12,7 +12,7 @@
 /**
  * External dependencies
  */
-import { get, mapValues, includes } from 'lodash';
+import { get, mapValues, includes, capitalize } from 'lodash';
 
 export const BACKSPACE = 8;
 export const TAB = 9;
@@ -81,7 +81,7 @@ export const displayShortcut = mapValues( modifiers, ( modifier ) => {
 		};
 		const shortcut = [
 			...modifier( _isMac ).map( ( key ) => get( replacementKeyMap, key, key ) ),
-			character.toUpperCase(),
+			capitalize( character ),
 		].join( '+' );
 
 		// Because we use just the clover symbol for MacOS's "command" key, remove

diff --git a/packages/keycodes/src/test/index.js b/packages/keycodes/src/test/index.js
@@ -24,7 +24,7 @@ describe( 'displayShortcut', () => {
 
 		it( 'outputs command+Del on MacOS (when the provided key is not a single character)', () => {
 			const shortcut = displayShortcut.primary( 'del', isMacOSTrue );
-			expect( shortcut ).toEqual( '⌘+DEL' );
+			expect( shortcut ).toEqual( '⌘+Del' );
 		} );
 	} );
 
@@ -41,7 +41,7 @@ describe( 'displayShortcut', () => {
 
 		it( 'outputs shift+command+Del on MacOS (when the provided key is not a single character)', () => {
 			const shortcut = displayShortcut.primaryShift( 'del', isMacOSTrue );
-			expect( shortcut ).toEqual( 'Shift+⌘+DEL' );
+			expect( shortcut ).toEqual( 'Shift+⌘+Del' );
 		} );
 	} );