Merge pull request #2341 from WordPress/fix/cover-image-modified-exte…

…rnally Cover Image: Extract title as children array (fix "modified externally")
WordPress · Aug 10, 2017 · fae7483 · fae7483
2 parents 6cf5da1 + ce77f24
commit fae7483
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/blocks/library/cover-image/index.js b/blocks/library/cover-image/index.js
@@ -19,7 +19,7 @@ import InspectorControls from '../../inspector-controls';
 import ToggleControl from '../../inspector-controls/toggle-control';
 import BlockDescription from '../../block-description';
 
-const { text } = source;
+const { children } = source;
 
 const validAlignments = [ 'left', 'center', 'right', 'wide', 'full' ];
 
@@ -32,8 +32,8 @@ registerBlockType( 'core/cover-image', {
 
 	attributes: {
 		title: {
-			type: 'string',
-			source: text( 'h2' ),
+			type: 'array',
+			source: children( 'h2' ),
 		},
 		url: {
 			type: 'string',

diff --git a/blocks/test/fixtures/core__cover-image.json b/blocks/test/fixtures/core__cover-image.json
@@ -4,7 +4,9 @@
         "name": "core/cover-image",
         "isValid": true,
         "attributes": {
-            "title": "Guten Berg!",
+            "title": [
+                "Guten Berg!"
+            ],
             "url": "https://cldup.com/uuUqE_dXzy.jpg",
             "hasParallax": false,
             "hasBackgroundDim": true