Try bundling sync package (#54738)

* Add sync package to bundled packages list * Wrap outputs in GB plugin check * Add sync to bundled packages in package config * Move plugin checks to core data * Move IS_GUTENBERG_PLUGIN inside __experimentalEnableSync checks --------- Co-authored-by: tellthemachines <isabel@tellthemachines.com>
WordPress · Sep 25, 2023 · fb1ebb1 · fb1ebb1 · github-actions · Sep 25, 2023
1 parent 7b6e996
commit fb1ebb1
Show file tree

Hide file tree

Showing 5 changed files with 52 additions and 40 deletions.
diff --git a/packages/core-data/src/actions.js b/packages/core-data/src/actions.js
@@ -385,12 +385,14 @@ export const editEntityRecord =
 			}, {} ),
 		};
 		if ( window.__experimentalEnableSync && entityConfig.syncConfig ) {
-			const objectId = entityConfig.getSyncObjectId( recordId );
-			getSyncProvider().update(
-				entityConfig.syncObjectType + '--edit',
-				objectId,
-				edit.edits
-			);
+			if ( process.env.IS_GUTENBERG_PLUGIN ) {
+				const objectId = entityConfig.getSyncObjectId( recordId );
+				getSyncProvider().update(
+					entityConfig.syncObjectType + '--edit',
+					objectId,
+					edit.edits
+				);
+			}
 		} else {
 			if ( ! options.undoIgnore ) {
 				select.getUndoManager().addRecord(

diff --git a/packages/core-data/src/entities.js b/packages/core-data/src/entities.js
@@ -401,8 +401,11 @@ export const getOrLoadEntitiesConfig =
 		let configs = select.getEntitiesConfig( kind );
 		if ( configs && configs.length !== 0 ) {
 			if ( window.__experimentalEnableSync ) {
-				registerSyncConfigs( configs );
+				if ( process.env.IS_GUTENBERG_PLUGIN ) {
+					registerSyncConfigs( configs );
+				}
 			}
+
 			return configs;
 		}
 
@@ -415,8 +418,11 @@ export const getOrLoadEntitiesConfig =
 
 		configs = await loader.loadEntities();
 		if ( window.__experimentalEnableSync ) {
-			registerSyncConfigs( configs );
+			if ( process.env.IS_GUTENBERG_PLUGIN ) {
+				registerSyncConfigs( configs );
+			}
 		}
+
 		dispatch( addEntities( configs ) );
 
 		return configs;

diff --git a/packages/core-data/src/resolvers.js b/packages/core-data/src/resolvers.js
@@ -79,39 +79,41 @@ export const getEntityRecord =
 				entityConfig.syncConfig &&
 				! query
 			) {
-				const objectId = entityConfig.getSyncObjectId( key );
-
-				// Loads the persisted document.
-				await getSyncProvider().bootstrap(
-					entityConfig.syncObjectType,
-					objectId,
-					( record ) => {
-						dispatch.receiveEntityRecords(
-							kind,
-							name,
-							record,
-							query
-						);
-					}
-				);
+				if ( process.env.IS_GUTENBERG_PLUGIN ) {
+					const objectId = entityConfig.getSyncObjectId( key );
+
+					// Loads the persisted document.
+					await getSyncProvider().bootstrap(
+						entityConfig.syncObjectType,
+						objectId,
+						( record ) => {
+							dispatch.receiveEntityRecords(
+								kind,
+								name,
+								record,
+								query
+							);
+						}
+					);
 
-				// Boostraps the edited document as well (and load from peers).
-				await getSyncProvider().bootstrap(
-					entityConfig.syncObjectType + '--edit',
-					objectId,
-					( record ) => {
-						dispatch( {
-							type: 'EDIT_ENTITY_RECORD',
-							kind,
-							name,
-							recordId: key,
-							edits: record,
-							meta: {
-								undo: undefined,
-							},
-						} );
-					}
-				);
+					// Boostraps the edited document as well (and load from peers).
+					await getSyncProvider().bootstrap(
+						entityConfig.syncObjectType + '--edit',
+						objectId,
+						( record ) => {
+							dispatch( {
+								type: 'EDIT_ENTITY_RECORD',
+								kind,
+								name,
+								recordId: key,
+								edits: record,
+								meta: {
+									undo: undefined,
+								},
+							} );
+						}
+					);
+				}
 			} else {
 				if ( query !== undefined && query._fields ) {
 					// If requesting specific fields, items and query association to said

diff --git a/packages/dependency-extraction-webpack-plugin/lib/util.js b/packages/dependency-extraction-webpack-plugin/lib/util.js
@@ -3,6 +3,7 @@ const BUNDLED_PACKAGES = [
 	'@wordpress/icons',
 	'@wordpress/interface',
 	'@wordpress/undo-manager',
+	'@wordpress/sync',
 ];
 
 /**

diff --git a/tools/webpack/packages.js b/tools/webpack/packages.js
@@ -28,6 +28,7 @@ const BUNDLED_PACKAGES = [
 	'@wordpress/icons',
 	'@wordpress/interface',
 	'@wordpress/undo-manager',
+	'@wordpress/sync',
 ];
 
 // PHP files in packages that have to be copied during build.