Default style variation label to match the is-style-default class name
#13660
Labels
Needs Design Feedback
Needs general design feedback.
Comments
This was referenced Feb 5, 2019
|
This sounds good to me 👍 👍 |
kjellr
added a commit
that referenced
this issue
Feb 5, 2019
Resolves #13660. This aligns the classname with the actual name we're using in the UI, and also allows for a bit more flexibility for default block styles per theme.
|
Sounds good! I opened #13670 to take care of this. |
kjellr
added a commit
that referenced
this issue
Feb 14, 2019
Resolves #13660. This aligns the classname with the actual name we're using in the UI, and also allows for a bit more flexibility for default block styles per theme.
youknowriad
pushed a commit
that referenced
this issue
Mar 6, 2019
Resolves #13660. This aligns the classname with the actual name we're using in the UI, and also allows for a bit more flexibility for default block styles per theme.
youknowriad
pushed a commit
that referenced
this issue
Mar 6, 2019
Resolves #13660. This aligns the classname with the actual name we're using in the UI, and also allows for a bit more flexibility for default block styles per theme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
The style variation for the separator block has the class
is-style-defaultin the code, but reflects the style variant as "Short line". Thanks to @webmandesign for this find! While the issue #10569 and PR #10570 suggest a change fromdefaulttoshortto match the name, it seems to lock in themes to use a 'short' line as their default. I believe @jasmussen explained it well in the PR review in #10570.Solution
Any block with style variations should reflect the word "Default" in the style variation preview as shown below.
This should apply to:
cc @jasmussen & @kjellr Does this sound right?
The text was updated successfully, but these errors were encountered: