Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component URLInput not honouring className prop #13754

Closed
dribba opened this issue Feb 7, 2019 · 1 comment · Fixed by #13800
Closed

Component URLInput not honouring className prop #13754

dribba opened this issue Feb 7, 2019 · 1 comment · Fixed by #13800
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Enhancement A suggestion for improvement.

Comments

@dribba
Copy link

dribba commented Feb 7, 2019 •
edited
Loading

Describe the bug
According to README.md, we should be able to pass a className prop (I assume to the <input?) into URLInput, after an attempt to use it and not being able to find the class applied to any element, I had a look at index.js where I don't see the className prop used at all.

To Reproduce
Steps to reproduce the behavior:

  1. Create a custom block type as in the example passing a custom className:
<URLInput
    className="custom-url-input"
    value={ attributes.url }
    onChange={ ( url, post ) => setAttributes( { url, text: (post && post.title) || 'Click here' } ) }
/>

Expected behavior
The className passed to be applied to one of the rendered elements.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop

  • OS: macOS
  • Browser: Firefox
  • Version: 64

Additional context

  • Default shipped with WordPress 5.0.3
@youknowriad youknowriad added [Type] Enhancement A suggestion for improvement. Good First Issue An issue that's suitable for someone looking to contribute for the first time [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later labels Feb 8, 2019
@youknowriad
Copy link
Contributor

Marked as a minor enhancement but the inconsistency with the docs is a bug in the docs right now.

ashwin-pc added a commit to ashwin-pc/gutenberg that referenced this issue Feb 9, 2019
@ashwin-pc
Fixed Component URLInput not honouring className
e42f775 
Related: WordPress#13754
This pull request fixes the URIInput Component not honouring. This add the className to the parent div for the component
This was referenced Feb 9, 2019
Closed
Merged
noisysocks pushed a commit that referenced this issue Feb 14, 2019
@ashwin-pc @noisysocks
Fixed Component URLInput not honouring className (#13800)
0ede174 
* Fixed Component URLInput not honouring className

Related: #13754
This pull request fixes the URIInput Component not honouring. This add the className to the parent div for the component

* Updated URLInput Readme for className prop
youknowriad pushed a commit that referenced this issue Mar 6, 2019
@ashwin-pc @youknowriad
Fixed Component URLInput not honouring className (#13800)
53f0250 
* Fixed Component URLInput not honouring className

Related: #13754
This pull request fixes the URIInput Component not honouring. This add the className to the parent div for the component

* Updated URLInput Readme for className prop
youknowriad pushed a commit that referenced this issue Mar 6, 2019
@ashwin-pc @youknowriad
Fixed Component URLInput not honouring className (#13800)
508a46c 
* Fixed Component URLInput not honouring className

Related: #13754
This pull request fixes the URIInput Component not honouring. This add the className to the parent div for the component

* Updated URLInput Readme for className prop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed Component URLInput not honouring className ashwin-pc/gutenberg
2 participants
@youknowriad @dribba