Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the horizontal centering of some button icons #1400

Closed
afercia opened this issue Jun 23, 2017 · 2 comments
Closed

Improve the horizontal centering of some button icons #1400

afercia opened this issue Jun 23, 2017 · 2 comments
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Task Issues or PRs that have been broken down into an individual action to take
Milestone
Merge: Editor

Comments

@afercia
Copy link
Contributor

afercia commented Jun 23, 2017

In the desktop view, there are two different types of buttons:

  • with text
  • without text

since the SVG icons have a default right margin of 4px, the icons of the buttons without text aren't really centered:

screen shot 2017-06-23 at 16 47 55

This changes in the responsive views, where the buttons text gets hidden and the buttons have a fixed width. However, in the desktop view we should maybe consider to remove the right margin for buttons without text.
@jasmussen jasmussen added Design Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Task Issues or PRs that have been broken down into an individual action to take labels Aug 18, 2017
@karmatosed karmatosed modified the milestones: Beta, Needs to happen, Beta 1.3 Sep 24, 2017
@karmatosed karmatosed modified the milestones: Beta 1.3, Beta, Needs to happen Oct 2, 2017
@Rahmon
Copy link
Contributor

Rahmon commented Oct 25, 2017

Is this still happening? The buttons without text apparently be centered.

gu

@mtias
Copy link
Member

mtias commented Nov 20, 2017

Going to close, feel free to reopen if you still experience this.

@mtias mtias closed this as completed Nov 20, 2017
youknowriad pushed a commit that referenced this issue Jan 17, 2020
@koke
Merge pull request #1400 from wordpress-mobile/media-text-stacking
a461fc8 
Make media-text respect stacking setting on native
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
Merge: Editor
Development

No branches or pull requests
5 participants
@karmatosed @mtias @jasmussen @afercia @Rahmon