Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heading block uses a counter-intuitive icon #15340

Closed
karlgroves opened this issue Apr 30, 2019 · 4 comments · Fixed by #15462
Closed

Heading block uses a counter-intuitive icon #15340

karlgroves opened this issue Apr 30, 2019 · 4 comments · Fixed by #15462
Assignees
Labels
[Block] Heading Affects the Headings Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@karlgroves
Copy link

Heading block uses a counter-intuitive icon

  • Severity: Low
  • Affected Populations:
    • Low-Vision
    • Cognitively Impaired
  • Platform(s):
    • All / Universal
  • Components affected:
    • Block Editing

Issue description

The "Block Type" menu, and block editor type button, use icons for
each block, and in most cases these are good representations of the
block. However the "Heading" block type uses the letter "T", which
is potentially confusing, since "Heading" doesn't start with "T".

Users with cognitive disabilities, especially those who are more
icon-reliant, may mistake the heading type for something else (such as
"Table" or "Text"), especially in cases where only the icon is
visible (such as in the block editor button, or when the "Block Type"
menu list is scrolled so that only the icon is visible).

Remediation Guidance

Use the letter "H" as the icon for the Heading block type. This also
matches the other H icons used for setting the level (H2, H3, etc.).

Relevant standards

Note: This issue may be a duplicate with other existing accessibility-related bugs in this project. This issue comes from the Gutenberg accessibility audit, performed by Tenon and funded by WP Campus. This issue is GUT-102 in Tenon's report

@gziolo gziolo added the Needs Accessibility Feedback Need input from accessibility label Apr 30, 2019
@mapk
Copy link
Contributor

mapk commented May 1, 2019

I'm not sure about the decision behind using the "T" but it could cognitively relate to "Title" as in the case of Material Icons.

Screen Shot 2019-05-01 at 9 41 56 AM

Also when looking at the case of formatting size, Material uses a small and larger "T" as the icon.

Screen Shot 2019-05-01 at 9 42 04 AM

I'm not opposed to using an "H" but would like to hear other design feedback first.

@mapk mapk added the Needs Design Feedback Needs general design feedback. label May 1, 2019
@sarahmonster
Copy link
Member

I believe there was a discussion about this some time ago, but I can't find it. The crux was that H wasn't inclusive of non-English languages.

We do use H for the heading levels, which feels a bit inconsistent:

Screenshot 2019-05-01 at 10 49 36

From a user experience perspective, my guess is that H is a more universal symbol for a heading element. That said, that might be coloured by my own experience as familiar with HTML and English-native. It would be super helpful to get some feedback from a variety of different languages here—maybe we could try a few different ideas and see what people respond best to.

For reference, Dropbox Paper uses "H1" and "H2", as does Bear. I haven't found many other instances of heading icons, but it's probably worth looking to see what standards may be established elsewhere.

@brentswisher
Copy link
Contributor

@sarahmonster Possible #9313 is what you were thinking of?

@mapk
Copy link
Contributor

mapk commented May 2, 2019

In today's slack triage, there was consensus around switching the "T" icon to an "H" because it related to the "H1", "H2", etc. tags in markup and might be more easily understood across languages.

Our next task is to get a PR created around this.

@mapk mapk removed the Needs Design Feedback Needs general design feedback. label May 2, 2019
@gziolo gziolo added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Block] Heading Affects the Headings Block [Type] Enhancement A suggestion for improvement. and removed Needs Accessibility Feedback Need input from accessibility labels May 4, 2019
@melchoyce melchoyce added the Needs Dev Ready for, and needs developer efforts label May 4, 2019
@marekhrabe marekhrabe added the [Status] In Progress Tracking issues with work in progress label May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Heading Affects the Headings Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants