Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-dom-server dependency build is broken #1628

Closed
nylen opened this issue Jul 1, 2017 · 1 comment
Closed

react-dom-server dependency build is broken #1628

nylen opened this issue Jul 1, 2017 · 1 comment
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript [Type] Bug An existing feature does not function as intended

Comments

@nylen
Copy link
Member

nylen commented Jul 1, 2017

While reviewing #1624 I noticed that
https://unpkg.com/react-dom@next/umd/react-dom-server.development.js is currently a bad build. This is breaking master for me 😞

It redirects to https://unpkg.com/react-dom@16.0.0-alpha.13/umd/react-dom-server.development.js which ends like this:

/**
* For browsers that do not provide the `textInput` event, extract the
* appropriate string to use for SyntheticInputEvent.
*
* @param {string} topLevelType Record from `BrowserEventConstants`.
* @param {object} nativeEvent Native browser event.
* @return {?string} The fallback string for this `beforeInput` event.
*/
function getFallbackBeforeInputChars(topLevelType, nativeEvent) {
 // If we are currently composing (IME) and using a fallback to do so,
 // try to extract the composed characters from the fallback object.
 // If composition event is available, we extract a string only at
 // compositionevent, otherwise extract it at fallback events.
 if (currentComposition) {
   if (topLevelType === 'topCompositionEnd' || !canUseCompositionEve

The alpha.12 version looks fine; here is what I did as a temp. fix

sudo -u www-data wget https://unpkg.com/react-dom@16.0.0-alpha.12/umd/react-dom-server.development.js -O vendor/react-dom-server.e84b9fa6.js

If this is not resolved soon, we can depend on this version directly instead of @next.

@nylen nylen added Framework Issues related to broader framework topics, especially as it relates to javascript [Type] Bug An existing feature does not function as intended labels Jul 1, 2017
@nylen
Copy link
Member Author

nylen commented Jul 3, 2017

This seems to have fixed itself.

@nylen nylen closed this as completed Jul 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

1 participant