Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build of react-dom-server on unpkg.com is broken #10086

Closed
nylen opened this issue Jul 1, 2017 · 2 comments
Closed

Build of react-dom-server on unpkg.com is broken #10086

nylen opened this issue Jul 1, 2017 · 2 comments

Comments

@nylen
Copy link

nylen commented Jul 1, 2017

I am not totally sure whether this should be reported here or against unpkg - for the issue against our project see WordPress/gutenberg#1628.


https://unpkg.com/react-dom@next/umd/react-dom-server.development.js is currently a bad build.

It redirects to https://unpkg.com/react-dom@16.0.0-alpha.13/umd/react-dom-server.development.js which ends like this:

/**
* For browsers that do not provide the `textInput` event, extract the
* appropriate string to use for SyntheticInputEvent.
*
* @param {string} topLevelType Record from `BrowserEventConstants`.
* @param {object} nativeEvent Native browser event.
* @return {?string} The fallback string for this `beforeInput` event.
*/
function getFallbackBeforeInputChars(topLevelType, nativeEvent) {
 // If we are currently composing (IME) and using a fallback to do so,
 // try to extract the composed characters from the fallback object.
 // If composition event is available, we extract a string only at
 // compositionevent, otherwise extract it at fallback events.
 if (currentComposition) {
   if (topLevelType === 'topCompositionEnd' || !canUseCompositionEve

The alpha.12 version looks fine.

@gaearon
Copy link
Collaborator

gaearon commented Jul 1, 2017

It doesn't end like this for me. I saw unpkg having issues like this before so let's assume the problem is on their side. If not let me know and I'll reopen.

@gaearon gaearon closed this as completed Jul 1, 2017
@nylen
Copy link
Author

nylen commented Jul 3, 2017

Looks fine to me now as well. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants