Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verse Block vs Code Block #16720

Closed
AlchemyUnited opened this issue Jul 23, 2019 · 1 comment
Closed

Verse Block vs Code Block #16720

AlchemyUnited opened this issue Jul 23, 2019 · 1 comment
Labels
[Block] Code Affects the Code Block [Block] Verse Affects the Verse block [Type] Question Questions about the design or development of the editor.

Comments

@AlchemyUnited
Copy link

AlchemyUnited commented Jul 23, 2019

Describe the bug
I'm not sure if this qualifies as a bug. It's likely it was a design decision somewhere along the way - as odd as it might be.

Long to short, in the editor Verse wraps its content in a < pre > tags. But Code does not. Why not? Is this because Code doesn't use RichText (which would give it a toolbar.).

Yet, on the frontend, both use the < pre > to wrap.

Again, feels minor, but none the less odd. Perhaps, if not already done do, this could be documented somewhere? For the sake of history?

@swissspidy swissspidy added [Block] Code Affects the Code Block [Block] Verse Affects the Verse block [Type] Question Questions about the design or development of the editor. labels Jul 24, 2019
@talldan
Copy link
Contributor

talldan commented Apr 23, 2020

@AlchemyUnited It now uses pre, since Gutenberg 7.9 (#21079).

Glad this has been resolved now, and the block should be consistent in the editor and the post.

@talldan talldan closed this as completed Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Code Affects the Code Block [Block] Verse Affects the Verse block [Type] Question Questions about the design or development of the editor.
Projects
None yet
Development

No branches or pull requests

3 participants