-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lighter block DOM: Code #21079
Lighter block DOM: Code #21079
Conversation
5165d94
to
83f5f04
Compare
Size Change: +23 B (0%) Total Size: 859 kB
ℹ️ View Unchanged
|
28c2556
to
2ae1596
Compare
ref={ ref } | ||
{ ...props } | ||
__unstableDisableFormats | ||
preserveWhiteSpace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose of this PR. Should it be enabled automatically for all EditableText components?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think, because in any kind of plain text, white space should not be collapsed (like a text area).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
1891940
to
3f8e3a3
Compare
Thanks @youknowriad! |
Description
Makes the Code block a light block and uses PlainText v2.
How has this been tested?
Screenshots
Types of changes
Checklist: