Lighter block DOM: Code #21079
Merged
Lighter block DOM: Code #21079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
requested review from
ajitbohra,
jorgefilipecosta,
Soean,
talldan and
youknowriad
as code owners
ellatrix
force-pushed
the
try/light-code-block
branch
from
5165d94
to
83f5f04
Compare
|
Size Change: +23 B (0%) Total Size: 859 kB
ℹ️ View Unchanged
|
youknowriad
reviewed
Mar 23, 2020
6 tasks
ellatrix
force-pushed
the
try/light-code-block
branch
from
28c2556
to
2ae1596
Compare
youknowriad
reviewed
Mar 25, 2020
| ref={ ref } | ||
| { ...props } | ||
| __unstableDisableFormats | ||
| preserveWhiteSpace |
There was a problem hiding this comment.
What's the purpose of this PR. Should it be enabled automatically for all EditableText components?
There was a problem hiding this comment.
Yes, I think, because in any kind of plain text, white space should not be collapsed (like a text area).
ellatrix
force-pushed
the
try/light-code-block
branch
from
1891940
to
3f8e3a3
Compare
|
Thanks @youknowriad! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes the Code block a light block and uses PlainText v2.
How has this been tested?
Screenshots
Types of changes
Checklist: