Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent blocks shows empty at times #1897

Closed
mtias opened this issue Jul 14, 2017 · 9 comments
Closed

Recent blocks shows empty at times #1897

mtias opened this issue Jul 14, 2017 · 9 comments
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Bug An existing feature does not function as intended

Comments

@mtias
Copy link
Member

mtias commented Jul 14, 2017

image

@notnownikki haven't debugged this one, but I've seen the recent blocks inserter ending up empty in different occasions.

@mtias mtias added [Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Bug An existing feature does not function as intended labels Jul 14, 2017
@notnownikki
Copy link
Member

That's super weird, never seen that happen! When you saw it then, were you changing tab back to recent, or just clicking on the inserter?

@mtias
Copy link
Member Author

mtias commented Jul 14, 2017

Just clicking on the inserter.

@notnownikki
Copy link
Member

What browser are you using? I can't reproduce this one 😞

I can see in the screenshot that you've got blocks added, so this suggests one of the following:

  1. Adding a block to the recently used list is going wrong, and we end up with an empty list - I can't see how this would happen, but lines 229-248 in editor/state.js are where this happens so if we see it happening, that's where we need some debug to find out if it's happening there.

  2. Connecting the redux state to the component is not getting the correct state. This is the part of the react/redux lifecycle I understand the least, so it's possible that's messing up somehow, but right now I can't see how.

I don't think this is anything to do with the search state, because the tabs are still rendering, so we're not searching - if we were, there would be no tabs.

@westonruter
Copy link
Member

@notnownikki I can reproduce this by opening an existing post in Gutenberg. Even though I have blocks in my content already, since I haven't actually inserted any blocks since I loaded the page, there is no data yet to populate the recent blocks. Is this not the same as #1859?

@notnownikki
Copy link
Member

Oh! Ok, it's not the same, as it seems I haven't hooked into all the correct actions, and #1859 is about providing the API for the current code to use. Thanks, I'll get on this, it should just be a matter on taking down which actions need to be responded to.

@notnownikki
Copy link
Member

Should be fixed in #1920

@hedgefield
Copy link

Have the same issue after updating to 0.5.0. It happens every time I open an existing post in gutenberg, like weston said.

@notnownikki
Copy link
Member

@hedgefield thanks for verifying 😄 I have a branch where this is fixed, we're just making sure that everything is in the right place and named correctly, as it introduces some hooks for loading and saving user specific data (such as block usage!)

@aduth
Copy link
Member

aduth commented Jul 21, 2017

Should be fixed by #1920

@aduth aduth closed this as completed Jul 21, 2017
Tug pushed a commit that referenced this issue Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

5 participants