Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social Icon Block Colours #20751

Closed
icc365 opened this issue Mar 10, 2020 · 3 comments · Fixed by #21474
Closed

Social Icon Block Colours #20751

icc365 opened this issue Mar 10, 2020 · 3 comments · Fixed by #21474
Assignees
Labels
[Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@icc365
Copy link

icc365 commented Mar 10, 2020

Describe the bug
Incorrect colours for the block social icon backgrounds as they relate to each social platform. I'm currently testing WordPress 5.4 RC1.

Expected behavior
Recommend either using a single colour, otherwise if the idea is to match the colours to the social networks, best to use their actual colours.

Example
Facebook colour in the block uses this HEX colour: #1977f2
The official colour for Facebook is: #3b5998

Additional context

  • Using and testing the WordPress 5.4 RC1 version.
@draganescu draganescu added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. labels Mar 10, 2020
@jasmussen
Copy link
Contributor

The colors for the facebook logo are taken from this document: https://en.facebookbrand.com/facebookapp/

Although the document mentions the term "app", it does show clear usage guidelines for how to use the brand colors, which appear to be correctly used by the block, if those guidelines are indeed the right ones.

I'm happy to submit a pull request to update the colors, but we have to find an official Facebook resource that suggests the color we're using is wrong first, otherwise we are not actually following official guidelines.

@jasmussen jasmussen added [Status] Needs More Info Follow-up required in order to be actionable. and removed Needs Design Feedback Needs general design feedback. labels Mar 10, 2020
@icc365
Copy link
Author

icc365 commented Mar 10, 2020

Thanks for the follow-up. Actually, it's many of the icon backgrounds that don't match the official colours, not just facebook. Although, I see facebook has changed their branding. From what I can tell, their blue is now #1778F2

The best thing to do if the colours are to get updated is to go to the official social sites and get their branded colour values. This might help too: https://www.lockedownseo.com/social-media-colors/

@jasmussen
Copy link
Contributor

I could swear I did exactly that! But I'll take another look 👍👍

@karmatosed karmatosed removed the [Status] Needs More Info Follow-up required in order to be actionable. label Mar 16, 2020
jasmussen added a commit that referenced this issue Apr 8, 2020
Fixes #20751.

Some colors were slightly off. This fixes that.
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Apr 8, 2020
jasmussen added a commit that referenced this issue Apr 8, 2020
Fixes #20751.

Some colors were slightly off. This fixes that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants