Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover: Default to "bottom right". #20765

Closed
jasmussen opened this issue Mar 10, 2020 · 0 comments
Closed

Popover: Default to "bottom right". #20765

jasmussen opened this issue Mar 10, 2020 · 0 comments
Labels
Needs Dev Ready for, and needs developer efforts

Comments

@jasmussen
Copy link
Contributor

It seems that if a position is not defined for a popover menu, it opens upwards from the center:

direction

This causes a great deal of inconsistency, as can be seen in the GIF above, with some menus opening in a way that seems intentional, and others opening in a seemingly arbitrary direction.

Should we add some defaults to the popover opening method, so it defaults to opening bottom right (with an extra rule for LTR)? That way we'd have some consistency by default, yet individual implementations can still override and customize.

CC: @ellatrix

@jasmussen jasmussen added the Needs Dev Ready for, and needs developer efforts label Mar 10, 2020
jasmussen added a commit that referenced this issue Apr 8, 2020
jasmussen added a commit that referenced this issue Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Dev Ready for, and needs developer efforts
Projects
None yet
Development

No branches or pull requests

1 participant