No TikTok icon for Social Icons block

[maddisondesigns]

Describe the bug
WordPress 5.4 provided a new TikTok embed, however it didn't provide a TikTok icon for the Social Icons block

To reproduce
Steps to reproduce the behavior:

1. Insert Social icons Block
2. Try to insert a TikTok icon

Expected behavior
TikTok needs to be added to the list of Social Icons

Editor version (please complete the following information):

• WordPress version: 5.4
• Does the website has Gutenberg plugin installed, or is it using the block editor that comes by default? Default
• If the Gutenberg plugin is installed, which version is it? [e.g., 7.6]

Desktop (please complete the following information):

• OS: macOS 10.15.4
• Browser: Firefox 75.0

[talldan]

Seems like a good suggestion!

Added 'Needs Design' as this will need an appropriate icon sourced.

[mattxwang]

I don't mind tackling this on the weekend if nobody else is - just to double-check, I'll add a tiktok.js file in packages/block-library/src/social-link/icons and update the packages/block-library/src/social-link/variations.js file with the relevant information, + add it in the index.php file? Should I update any docs somewhere? How should I go about writing an E2E test?

[talldan]

@malsf21 Thanks for picking this up! What you mentioned sounds about right.

In terms of testing, there are some fixtures that test the block save output in this folder:
https://github.com/WordPress/gutenberg/tree/master/packages/e2e-tests/fixtures/blocks

You'd be looking to add a core__social-link-tiktok.html file. What I usually do is add the block in the editor and then grab the HTML for the block from the code editor view and paste it into the file.

Then running this command generates the other three files for the fixture:

GENERATE_MISSING_FIXTURES=y npm run test-unit test/integration/full-content/full-content.test.js

It doesn't look like there are any e2e tests for the social icons block, so I wouldn't worry about that on your PR, though separate PRs for e2e tests are always welcome. 😄

[mattxwang]

Great, thank you for the guidance @talldan! I've already added the relevant files on my local fork, and this weekend I'll add the core__social-link-tiktok.html file and related fixtures, and submit a PR to close this issue.