-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename "Mail" icon or add alternate name to cover "Email" #21733
Comments
I'll ping Marcus @mkaz as he has been doing a lot of work with the Social Block. |
@mkaz Thanks for the clarification. I've updated the title to cover my issue (not being able to find it). |
@jasmussen What do you think of adding an additional icon named "email" that is an "@" ? This would give someone the choice of type of email icons. I also think a helper to prefill the |
re: Icon - FWIW, I don't care that much about a second icon. I only mentioned it since I thought one needed to be designed. re: "mailto: - I didn't realize there wasn't a prefill. The placeholder text says "enter email" so that's all I did. I think that is an absolute requirement. And if we're adding one helper, I just want to plug one more time, if it's easy to obfuscate the address a la |
There are a number of ways to go about this. Aside from the direct path — adding an @ icon to the new Icon component first, then adding a new generic "@ address" child block for social links. That seems to be the task attached to this ticket. An additional path is to enable this without needing to wait for this ticket to be addressed, then for the PR to land in the plugin and ultimately WordPress. Specifically:
Combining the above two the goal would be to enable anyone to add a social link block for any purpose, or even for a plugin to extend the social links block. |
@jasmussen @mkaz I'd like to refocus this ticket on my primary concern and the reason I opened it. Searching the social icons for "email" does not have a result. This lead me to think that email wasn't an option. Here's the issue summarized in a screenshot: I tried renaming the ticket to make this clearer, but feel free to re-rename to whatever will clarify the purpose of the ticket. As @jasmussen mentions, there's already a ticket for extensibility, and I will open up a separate ticket for "mailto:" and obfuscation. |
This makes the mail icon show if the user searches for mail or email. The property value does not change, it stays as 'mail' so is still compatibility with any existing social links. The title change only allows it show up in search for both. Fixes #21733
This makes the mail icon show if the user searches for mail or email. The property value does not change, it stays as 'mail' so is still compatibility with any existing social links. The title change only allows it show up in search for both. Fixes #21733
* Social Link: Rename mail to email This makes the mail icon show if the user searches for mail or email. The property value does not change, it stays as 'mail' so is still compatibility with any existing social links. The title change only allows it show up in search for both. Fixes #21733 * Social: Add email keyowrds to mail variation
Is your feature request related to a problem? Please describe.
While not strictly "social media", email is often included in a row of social icons, especially on a staff/team page where this block is especially useful.
Describe the solution you'd like
An email icon (probably a postal letter or "@" symbol) that outputs a mailto: link would be great. Running that email through
antispambot()
would be even better!The text was updated successfully, but these errors were encountered: