Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "Mail" icon or add alternate name to cover "Email" #21733

Closed
mrwweb opened this issue Apr 20, 2020 · 7 comments · Fixed by #25924
Closed

Rename "Mail" icon or add alternate name to cover "Email" #21733

mrwweb opened this issue Apr 20, 2020 · 7 comments · Fixed by #25924
Assignees
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@mrwweb
Copy link

mrwweb commented Apr 20, 2020

Is your feature request related to a problem? Please describe.
While not strictly "social media", email is often included in a row of social icons, especially on a staff/team page where this block is especially useful.

Describe the solution you'd like
An email icon (probably a postal letter or "@" symbol) that outputs a mailto: link would be great. Running that email through antispambot() would be even better!

@talldan talldan added [Block] Social Affects the Social Block - used to display Social Media accounts [Type] Enhancement A suggestion for improvement. labels Apr 21, 2020
@paaljoachim
Copy link
Contributor

I'll ping Marcus @mkaz as he has been doing a lot of work with the Social Block.

@mkaz
Copy link
Member

mkaz commented Apr 23, 2020

The icon is already there, its just called Mail and not Email.

social-mailto

@mrwweb mrwweb changed the title Add "Email" icon to Social Block Rename "Mail" icon or add alternate name to cover "Email" Apr 23, 2020
@mrwweb
Copy link
Author

mrwweb commented Apr 23, 2020

@mkaz Thanks for the clarification. I've updated the title to cover my issue (not being able to find it).

@mkaz
Copy link
Member

mkaz commented Apr 23, 2020

@jasmussen What do you think of adding an additional icon named "email" that is an "@" ? This would give someone the choice of type of email icons.

I also think a helper to prefill the mailto: portion would be nice, could be useful for many sites. For example Twitter could use a prefill: https://twitter.com/

@mrwweb
Copy link
Author

mrwweb commented Apr 23, 2020

re: Icon - FWIW, I don't care that much about a second icon. I only mentioned it since I thought one needed to be designed.

re: "mailto: - I didn't realize there wasn't a prefill. The placeholder text says "enter email" so that's all I did. I think that is an absolute requirement.

And if we're adding one helper, I just want to plug one more time, if it's easy to obfuscate the address a la antispambot(), there's no excuse not to do it!

@jasmussen
Copy link
Contributor

There are a number of ways to go about this. Aside from the direct path — adding an @ icon to the new Icon component first, then adding a new generic "@ address" child block for social links. That seems to be the task attached to this ticket.

An additional path is to enable this without needing to wait for this ticket to be addressed, then for the PR to land in the plugin and ultimately WordPress. Specifically:

Combining the above two the goal would be to enable anyone to add a social link block for any purpose, or even for a plugin to extend the social links block.

@mrwweb
Copy link
Author

mrwweb commented Apr 24, 2020

@jasmussen @mkaz I'd like to refocus this ticket on my primary concern and the reason I opened it.

Searching the social icons for "email" does not have a result. This lead me to think that email wasn't an option.

Here's the issue summarized in a screenshot:

social icon block search for "email" provides no results

I tried renaming the ticket to make this clearer, but feel free to re-rename to whatever will clarify the purpose of the ticket.

As @jasmussen mentions, there's already a ticket for extensibility, and I will open up a separate ticket for "mailto:" and obfuscation.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 7, 2020
mkaz added a commit that referenced this issue Oct 8, 2020
This makes the mail icon show if the user searches for mail or email.
The property value does not change, it stays as 'mail' so is still
compatibility with any existing social links.

The title change only allows it show up in search for both.

Fixes #21733
mkaz added a commit that referenced this issue Oct 8, 2020
This makes the mail icon show if the user searches for mail or email.
The property value does not change, it stays as 'mail' so is still
compatibility with any existing social links.

The title change only allows it show up in search for both.

Fixes #21733
mkaz added a commit that referenced this issue Oct 8, 2020
* Social Link: Rename mail to email

This makes the mail icon show if the user searches for mail or email.
The property value does not change, it stays as 'mail' so is still
compatibility with any existing social links.

The title change only allows it show up in search for both.

Fixes #21733

* Social: Add email keyowrds to mail variation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants
@mkaz @talldan @jasmussen @mrwweb @paaljoachim and others