Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post locked modal: the Preview link is hidden but then displayed only for small screens #24381

Closed
afercia opened this issue Aug 5, 2020 · 0 comments · Fixed by #24487
Closed
Assignees
Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Aug 5, 2020

Describe the bug

When a post is locked because it's already being edited by another user, the "post locked" modal dialog appears. On desktop, it shows only the "Exit the Editor" and "Take Over" links. Although the "Preview" link is rendered, it's hidden because of this CSS rule:

@media (min-width: 600px)
.editor-post-preview {
    display: none;
}

Screenshot 2020-08-05 at 17 40 53

With a viewport width smaller than 600 pixels, the Preview link is shown:

Screenshot 2020-08-05 at 17 41 37

Not sure this is the intended behavior. I'd tend to think the Preview link within this modal dialog should always be displayed. The CSS rule above appear to be intended for the Preview link in the top toolbar, which replaces the Preview menu under 600 pixels.

Also to note:

  • the different styling of the Preview link
  • the modal dialog is not centered on small screens

Editor version (please complete the following information):

  • WordPress version: [e.g: 5.3.2] 5.5 RC 2
  • Does the website has Gutenberg plugin installed, or is it using the block editor that comes by default? Default
@afercia afercia added the [Type] Bug An existing feature does not function as intended label Aug 5, 2020
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants