Fix: Post preview button only appears on small screens #24487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
the
[Type] Bug
jorgefilipecosta
requested review from
ellatrix and
youknowriad
as code owners
|
Size Change: +12 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
jorgefilipecosta
deleted the
fix/post-preview-button-only-appears-on-small-screens
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #24381
We have a rule that on non-small screens hides the preview button (on the header at the side of the publish button) and instead displays a component that allows simulating a specific device size.
That rule was to generic and hided every use case of the PostPreviewButton component causing bug #24381.
This PR makes sure the rule only applies inside the header section making other post preview buttons work normally.
How has this been tested?
Repeated the steps from #24381 and verified the issue does not happen anymore.
Verified the behavior of the preview functionality still works as expected on desktop and mobile.