Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sibling Inserter: Broken positioning on Site Editor #28827

Closed
jasmussen opened this issue Feb 8, 2021 · 3 comments
Closed

Sibling Inserter: Broken positioning on Site Editor #28827

jasmussen opened this issue Feb 8, 2021 · 3 comments
Labels
[Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release

Comments

@jasmussen
Copy link
Contributor

The sibling inserter shows up when you hover between two blocks, whether in the post or site editor:

before-commit

This still works fine on the post editor, but regressed on the site editor, where it's offset about 60px upwards:

after commit

The precise amount of vertical offset does not appear to be constant, and appears to depend on which blocks are present on the page. With a few cover and spacer blocks, it's very offset. With just paragraphs, it's almost correct.

In trying to figure out how this regressed, I walked back in time on the commits page (https://github.com/WordPress/gutenberg/commits/master?before=e843e5484e2087d1ef546564c09254cc60dc5170+230&branch=master), and from this digging (I really need to learn to bisect), this appears to have been caused by #27860.

@jasmussen jasmussen added [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release labels Feb 8, 2021
@youknowriad
Copy link
Contributor

Is it the same as ##28457 ?

@jasmussen
Copy link
Contributor Author

It is. My apologies!

@youknowriad
Copy link
Contributor

No worries, just saw it mentioned in a potential PR that can fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

No branches or pull requests

2 participants