Try more muted sibling inserter. #28550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -28 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
This works fine in post editor but I'm noticing some vertical positioning weirdness in Site Editor. It makes it impossible to use in horizontal orientation.
|
|
This PR shouldn't have touched the vertical positioning of in the site editor. |
You are right, I checked with some of the prior commits and it's still reproducible. I misattributed it to this PR after checking the blame and seeing that it was the last change to the relevant CSS, and it was also changing the |
|
No worries 😅 I created an issue myself that I closed as a duplicate when I discovered the existing one: #28827 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sibling inserter recently received an animated blue border extending from the center, to indicate orientation of the block being inserted. This is beautiful and useful, but also slightly noisy and prominent in consideration of the writing flow. It also removed the slight delay that showed the inserter only after a little pause:
This PR pulls it back a little:
On the whole, I feel like that grounds the sibling inserter to strike a better balance, remain useful, while being less noisy. What do you think?