Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The text prop is missing from the button component documentation #30621

Closed
johnbillion opened this issue Apr 8, 2021 · 2 comments · Fixed by #30796
Closed

The text prop is missing from the button component documentation #30621

johnbillion opened this issue Apr 8, 2021 · 2 comments · Fixed by #30796
Assignees
@dhruvkb
Labels
[Feature] UI Components Impacts or related to the UI component system [Package] Components /packages/components [Status] In Progress Tracking issues with work in progress [Type] Developer Documentation Documentation for developers

Comments

@johnbillion
Copy link
Member

johnbillion commented Apr 8, 2021 •
edited
Loading

Description

The Button component has a text prop which is missing from the documentation for the button component.

There may be other missing props for this, I've not checked in depth.
@talldan
Copy link
Contributor

talldan commented Apr 9, 2021

@johnbillion It looks like you're right that the Button react component does indeed have an undocumented text attribute.

However it's unrelated to do with the core/button block, which is implemented as a RichText anchor tag. Would you be able to update the issue description to remove mention of the block?

@talldan talldan added [Feature] UI Components Impacts or related to the UI component system [Package] Components /packages/components [Type] Developer Documentation Documentation for developers labels Apr 9, 2021
@johnbillion johnbillion changed the title The text attribute is missing from the button block type documentation The text attribute is missing from the button component documentation Apr 9, 2021
@johnbillion
Copy link
Member Author

Looks like I got confused here. Thanks Dan. I've updated the issue.

@johnbillion johnbillion changed the title The text attribute is missing from the button component documentation The text prop is missing from the button component documentation Apr 9, 2021
@dhruvkb dhruvkb mentioned this issue Apr 13, 2021
Merged
7 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhruvkb dhruvkb

Labels
[Feature] UI Components Impacts or related to the UI component system [Package] Components /packages/components [Status] In Progress Tracking issues with work in progress [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add documentation for the text prop on the Button component
3 participants
@johnbillion @talldan @dhruvkb