Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for the text prop on the Button component #30796

Merged
merged 1 commit into from
Apr 14, 2021
Merged

Add documentation for the text prop on the Button component #30796

merged 1 commit into from
Apr 14, 2021

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Apr 13, 2021

Description

This PR adds documentation for the text prop on the Button component.

Fixes #30621

How has this been tested?

Verified behaviour using the Storybook.

Screenshots

Types of changes

This PR adds missing documentation. Could be classified as a bug fix.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@dhruvkb dhruvkb added the [Type] Developer Documentation Documentation for developers label Apr 13, 2021
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @dhruvkb! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Apr 13, 2021
Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dhruvkb. Congrats on your first contribution!

@talldan talldan added the [Feature] UI Components Impacts or related to the UI component system label Apr 14, 2021
@talldan talldan merged commit 930d0ce into WordPress:trunk Apr 14, 2021
@talldan talldan changed the title Add documentation for the prop on the Button component Add documentation for the text prop on the Button component Apr 14, 2021
@github-actions github-actions bot added this to the Gutenberg 10.5 milestone Apr 14, 2021
@dhruvkb dhruvkb deleted the button_text_prop branch April 14, 2021 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] UI Components Impacts or related to the UI component system First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The text prop is missing from the button component documentation
2 participants